Loading camera/VendorTagDescriptor.cpp +2 −2 Original line number Diff line number Diff line Loading @@ -192,7 +192,7 @@ status_t VendorTagDescriptor::readFromParcel(const Parcel* parcel) { // Set up reverse mapping for (size_t i = 0; i < static_cast<size_t>(tagCount); ++i) { uint32_t tag = allTags[i]; String8 sectionString = mSections[mTagToSectionMap.valueFor(tag)]; const String8& sectionString = mSections[mTagToSectionMap.valueFor(tag)]; ssize_t reverseIndex = -1; if ((reverseIndex = mReverseMapping.indexOfKey(sectionString)) < 0) { Loading Loading @@ -284,7 +284,7 @@ SortedVector<String8> VendorTagDescriptor::getAllSectionNames() const { return mSections; } status_t VendorTagDescriptor::lookupTag(String8 name, String8 section, /*out*/uint32_t* tag) const { status_t VendorTagDescriptor::lookupTag(const String8& name, const String8& section, /*out*/uint32_t* tag) const { ssize_t index = mReverseMapping.indexOfKey(section); if (index < 0) { ALOGE("%s: Section '%s' does not exist.", __FUNCTION__, section.string()); Loading include/camera/VendorTagDescriptor.h +1 −1 Original line number Diff line number Diff line Loading @@ -89,7 +89,7 @@ class VendorTagDescriptor : public Parcelable { * * Returns OK on success, or a negative error code. */ status_t lookupTag(String8 name, String8 section, /*out*/uint32_t* tag) const; status_t lookupTag(const String8& name, const String8& section, /*out*/uint32_t* tag) const; /** * Dump the currently configured vendor tags to a file descriptor. Loading services/camera/libcameraservice/CameraFlashlight.cpp +1 −1 Original line number Diff line number Diff line Loading @@ -812,7 +812,7 @@ status_t CameraHardwareInterfaceFlashControl::getSmallestSurfaceSize( } status_t CameraHardwareInterfaceFlashControl::initializePreviewWindow( sp<CameraHardwareInterface> device, int32_t width, int32_t height) { const sp<CameraHardwareInterface>& device, int32_t width, int32_t height) { status_t res; BufferQueue::createBufferQueue(&mProducer, &mConsumer); Loading services/camera/libcameraservice/CameraFlashlight.h +1 −1 Original line number Diff line number Diff line Loading @@ -193,7 +193,7 @@ class CameraHardwareInterfaceFlashControl : public FlashControlBase { status_t disconnectCameraDevice(); // initialize the preview window status_t initializePreviewWindow(sp<CameraHardwareInterface> device, status_t initializePreviewWindow(const sp<CameraHardwareInterface>& device, int32_t width, int32_t height); // start preview and enable torch Loading services/camera/libcameraservice/CameraService.cpp +2 −2 Original line number Diff line number Diff line Loading @@ -2367,7 +2367,7 @@ String8 CameraService::CameraState::getId() const { void CameraService::ClientEventListener::onClientAdded( const resource_policy::ClientDescriptor<String8, sp<CameraService::BasicClient>>& descriptor) { auto basicClient = descriptor.getValue(); const auto& basicClient = descriptor.getValue(); if (basicClient.get() != nullptr) { BatteryNotifier& notifier(BatteryNotifier::getInstance()); notifier.noteStartCamera(descriptor.getKey(), Loading @@ -2378,7 +2378,7 @@ void CameraService::ClientEventListener::onClientAdded( void CameraService::ClientEventListener::onClientRemoved( const resource_policy::ClientDescriptor<String8, sp<CameraService::BasicClient>>& descriptor) { auto basicClient = descriptor.getValue(); const auto& basicClient = descriptor.getValue(); if (basicClient.get() != nullptr) { BatteryNotifier& notifier(BatteryNotifier::getInstance()); notifier.noteStopCamera(descriptor.getKey(), Loading Loading
camera/VendorTagDescriptor.cpp +2 −2 Original line number Diff line number Diff line Loading @@ -192,7 +192,7 @@ status_t VendorTagDescriptor::readFromParcel(const Parcel* parcel) { // Set up reverse mapping for (size_t i = 0; i < static_cast<size_t>(tagCount); ++i) { uint32_t tag = allTags[i]; String8 sectionString = mSections[mTagToSectionMap.valueFor(tag)]; const String8& sectionString = mSections[mTagToSectionMap.valueFor(tag)]; ssize_t reverseIndex = -1; if ((reverseIndex = mReverseMapping.indexOfKey(sectionString)) < 0) { Loading Loading @@ -284,7 +284,7 @@ SortedVector<String8> VendorTagDescriptor::getAllSectionNames() const { return mSections; } status_t VendorTagDescriptor::lookupTag(String8 name, String8 section, /*out*/uint32_t* tag) const { status_t VendorTagDescriptor::lookupTag(const String8& name, const String8& section, /*out*/uint32_t* tag) const { ssize_t index = mReverseMapping.indexOfKey(section); if (index < 0) { ALOGE("%s: Section '%s' does not exist.", __FUNCTION__, section.string()); Loading
include/camera/VendorTagDescriptor.h +1 −1 Original line number Diff line number Diff line Loading @@ -89,7 +89,7 @@ class VendorTagDescriptor : public Parcelable { * * Returns OK on success, or a negative error code. */ status_t lookupTag(String8 name, String8 section, /*out*/uint32_t* tag) const; status_t lookupTag(const String8& name, const String8& section, /*out*/uint32_t* tag) const; /** * Dump the currently configured vendor tags to a file descriptor. Loading
services/camera/libcameraservice/CameraFlashlight.cpp +1 −1 Original line number Diff line number Diff line Loading @@ -812,7 +812,7 @@ status_t CameraHardwareInterfaceFlashControl::getSmallestSurfaceSize( } status_t CameraHardwareInterfaceFlashControl::initializePreviewWindow( sp<CameraHardwareInterface> device, int32_t width, int32_t height) { const sp<CameraHardwareInterface>& device, int32_t width, int32_t height) { status_t res; BufferQueue::createBufferQueue(&mProducer, &mConsumer); Loading
services/camera/libcameraservice/CameraFlashlight.h +1 −1 Original line number Diff line number Diff line Loading @@ -193,7 +193,7 @@ class CameraHardwareInterfaceFlashControl : public FlashControlBase { status_t disconnectCameraDevice(); // initialize the preview window status_t initializePreviewWindow(sp<CameraHardwareInterface> device, status_t initializePreviewWindow(const sp<CameraHardwareInterface>& device, int32_t width, int32_t height); // start preview and enable torch Loading
services/camera/libcameraservice/CameraService.cpp +2 −2 Original line number Diff line number Diff line Loading @@ -2367,7 +2367,7 @@ String8 CameraService::CameraState::getId() const { void CameraService::ClientEventListener::onClientAdded( const resource_policy::ClientDescriptor<String8, sp<CameraService::BasicClient>>& descriptor) { auto basicClient = descriptor.getValue(); const auto& basicClient = descriptor.getValue(); if (basicClient.get() != nullptr) { BatteryNotifier& notifier(BatteryNotifier::getInstance()); notifier.noteStartCamera(descriptor.getKey(), Loading @@ -2378,7 +2378,7 @@ void CameraService::ClientEventListener::onClientAdded( void CameraService::ClientEventListener::onClientRemoved( const resource_policy::ClientDescriptor<String8, sp<CameraService::BasicClient>>& descriptor) { auto basicClient = descriptor.getValue(); const auto& basicClient = descriptor.getValue(); if (basicClient.get() != nullptr) { BatteryNotifier& notifier(BatteryNotifier::getInstance()); notifier.noteStopCamera(descriptor.getKey(), Loading