Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f29dc043 authored by Chih-Hung Hsieh's avatar Chih-Hung Hsieh
Browse files

Suppress bogus static analysis warnings. 

* clang-analyzer-cplusplus.NewDelete and clang-analyzer-unix.Malloc
  could give wrong "Use of memory after it is freed" warnings.
* Delete old obsolet calls to ALOGV.

Test: make with WITH_TIDY=1
Change-Id: Ie7806c8d423b31e8b527b42ad15469d0b087edfa
parent a7dbdc85

media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp

+0 −6
Original line number Diff line number Diff line
@@ -1238,13 +1238,7 @@ void LvmEffect_free(EffectContext *pContext){ 
    for (int i=0; i<LVM_NR_MEMORY_REGIONS; i++){

        if (MemTab.Region[i].Size != 0){

            if (MemTab.Region[i].pBaseAddress != NULL){

                ALOGV("\tLvmEffect_free - START freeing %" PRIu32 " bytes for region %u at %p\n",

                        MemTab.Region[i].Size, i, MemTab.Region[i].pBaseAddress);



                free(MemTab.Region[i].pBaseAddress);



                ALOGV("\tLvmEffect_free - END   freeing %" PRIu32 " bytes for region %u at %p\n",

                        MemTab.Region[i].Size, i, MemTab.Region[i].pBaseAddress);

            }else{

                ALOGV("\tLVM_ERROR : LvmEffect_free - trying to free with NULL pointer %" PRIu32

                        " bytes for region %u at %p ERROR\n",

media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp

+0 −6
Original line number Diff line number Diff line
@@ -689,13 +689,7 @@ void Reverb_free(ReverbContext *pContext){ 
    for (int i=0; i<LVM_NR_MEMORY_REGIONS; i++){

        if (MemTab.Region[i].Size != 0){

            if (MemTab.Region[i].pBaseAddress != NULL){

                ALOGV("\tfree() - START freeing %" PRIu32 " bytes for region %u at %p\n",

                        MemTab.Region[i].Size, i, MemTab.Region[i].pBaseAddress);



                free(MemTab.Region[i].pBaseAddress);



                ALOGV("\tfree() - END   freeing %" PRIu32 " bytes for region %u at %p\n",

                        MemTab.Region[i].Size, i, MemTab.Region[i].pBaseAddress);

            }else{

                ALOGV("\tLVM_ERROR : free() - trying to free with NULL pointer %" PRIu32 " bytes "

                        "for region %u at %p ERROR\n",

media/libeffects/preprocessing/PreProcessing.cpp

+1 −1
Original line number Diff line number Diff line
@@ -889,7 +889,7 @@ error: 
        delete session->procFrame;

        session->procFrame = NULL;

        delete session->apm;

        session->apm = NULL;

        session->apm = NULL; // NOLINT(clang-analyzer-cplusplus.NewDelete)

    }

    return status;

}