Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ea18634f authored by Dean Wheatley's avatar Dean Wheatley
Browse files

Fix "don't leak AUDIO_INPUT_FLAG_DIRECT to HAL version <= 5" 

Test: MSD to downstream patch creation on Audio HAL v4 MSD HAL
      (hikey960)
Change-Id: Icbe5f6b8b49dc9f34cc01814da5c17653f3df5fd
parent 261d874a

media/libaudiohal/impl/DeviceHalHidl.cpp

+4 −4
Original line number Diff line number Diff line
@@ -246,6 +246,10 @@ status_t DeviceHalHidl::openInputStream( 
        return status;

    }

    CoreUtils::AudioInputFlags hidlFlags;

#if MAJOR_VERSION <= 5

    // Some flags were specific to framework and must not leak to the HAL.

    flags = static_cast<audio_input_flags_t>(flags & ~AUDIO_INPUT_FLAG_DIRECT);

#endif

    if (status_t status = CoreUtils::audioInputFlagsFromHal(flags, &hidlFlags); status != OK) {

        return status;

    }
@@ -277,10 +281,6 @@ status_t DeviceHalHidl::openInputStream( 
        }

        sinkMetadata.tracks[0].destination.device(std::move(hidlOutputDevice));

    }

#endif

#if MAJOR_VERSION <= 5

    // Some flags were specific to framework and must not leak to the HAL.

    flags = static_cast<audio_input_flags_t>(flags & ~AUDIO_INPUT_FLAG_DIRECT);

#endif

    Return<void> ret = mDevice->openInputStream(

            handle, hidlDevice, hidlConfig, hidlFlags, sinkMetadata,