Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e7511472 authored by Yin-Chia Yeh's avatar Yin-Chia Yeh Committed by Xin Li
Browse files

Camera: fix wrong signalStreamFlush call 

Sometimes the waitUntilIdle call will finish without RequestThread
sending the signalStreamFlush call down to HAL.
Reset the flag when the wait finishes to avoid a wrong call fired
later when the request thread goes to paused.

Test: CTS on Pixel 3, partner testing
Bug: 162062652
Change-Id: I7c6674860a688f0bc42d4083793514b546cbd65d
(cherry picked from commit e52b8fa8)
parent 1a342950

services/camera/libcameraservice/device3/Camera3Device.cpp

+12 −0
Original line number Diff line number Diff line
@@ -1833,10 +1833,12 @@ status_t Camera3Device::waitUntilStateThenRelock(bool active, nsecs_t timeout) { 


    mStatusWaiters++;



    bool signalPipelineDrain = false;

    if (!active && mUseHalBufManager) {

        auto streamIds = mOutputStreams.getStreamIds();

        if (mStatus == STATUS_ACTIVE) {

            mRequestThread->signalPipelineDrain(streamIds);

            signalPipelineDrain = true;

        }

        mRequestBufferSM.onWaitUntilIdle();

    }
@@ -1866,6 +1868,10 @@ status_t Camera3Device::waitUntilStateThenRelock(bool active, nsecs_t timeout) { 
        }

    } while (!stateSeen);



    if (signalPipelineDrain) {

        mRequestThread->resetPipelineDrain();

    }



    mStatusWaiters--;



    return res;
@@ -4785,6 +4791,12 @@ void Camera3Device::RequestThread::signalPipelineDrain(const std::vector<int>& s 
    mStreamIdsToBeDrained = streamIds;

}



void Camera3Device::RequestThread::resetPipelineDrain() {

    Mutex::Autolock pl(mPauseLock);

    mNotifyPipelineDrain = false;

    mStreamIdsToBeDrained.clear();

}



void Camera3Device::RequestThread::clearPreviousRequest() {

    Mutex::Autolock l(mRequestLock);

    mPrevRequest.clear();

services/camera/libcameraservice/device3/Camera3Device.h

+1 −0
Original line number Diff line number Diff line
@@ -832,6 +832,7 @@ class Camera3Device : 
        }



        void signalPipelineDrain(const std::vector<int>& streamIds);

        void resetPipelineDrain();



        status_t switchToOffline(

                const std::vector<int32_t>& streamsToKeep,