Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e659ef42 authored by Eric Laurent's avatar Eric Laurent
Browse files

audioflinger: forward flush to direct output streams 

Track flush should be forwarded to the audio HAL when playing
on a direct output stream.

Bug: 17704953.
Change-Id: Iafc94327fe9aebf1d4eaa97b76c6767b7ac5babe
parent dc2e6ddc

services/audioflinger/Threads.cpp

+10 −1
Original line number Diff line number Diff line
@@ -4040,6 +4040,9 @@ AudioFlinger::PlaybackThread::mixer_state AudioFlinger::DirectOutputThread::prep 
                        track->mState = TrackBase::STOPPED;

                    }

                    if (track->isStopped()) {

                        if (track->mState == TrackBase::FLUSHED) {

                            flushHw_l();

                        }

                        track->reset();

                    }

                    tracksToRemove->add(track);
@@ -4212,6 +4215,12 @@ void AudioFlinger::DirectOutputThread::cacheParameters_l() 
    }

}



void AudioFlinger::DirectOutputThread::flushHw_l()

{

    if (mOutput->stream->flush != NULL)

        mOutput->stream->flush(mOutput->stream);

}



// ----------------------------------------------------------------------------



AudioFlinger::AsyncCallbackThread::AsyncCallbackThread(
@@ -4579,7 +4588,7 @@ bool AudioFlinger::OffloadThread::waitingAsyncCallback() 


void AudioFlinger::OffloadThread::flushHw_l()

{

    mOutput->stream->flush(mOutput->stream);

    DirectOutputThread::flushHw_l();

    // Flush anything still waiting in the mixbuffer

    mCurrentWriteLength = 0;

    mBytesRemaining = 0;

services/audioflinger/Threads.h

+2 −3
Original line number Diff line number Diff line
@@ -894,6 +894,7 @@ public: 


    virtual     bool        checkForNewParameter_l(const String8& keyValuePair,

                                                   status_t& status);

    virtual     void        flushHw_l();



protected:

    virtual     int         getTrackName_l(audio_channel_mask_t channelMask,
@@ -929,6 +930,7 @@ public: 
    OffloadThread(const sp<AudioFlinger>& audioFlinger, AudioStreamOut* output,

                        audio_io_handle_t id, uint32_t device);

    virtual                 ~OffloadThread() {};

    virtual     void        flushHw_l();



protected:

    // threadLoop snippets
@@ -940,9 +942,6 @@ protected: 
    virtual     bool        shouldStandby_l();

    virtual     void        onAddNewTrack_l();



private:

                void        flushHw_l();



private:

    bool        mHwPaused;

    bool        mFlushPending;

services/audioflinger/Tracks.cpp

+4 −0
Original line number Diff line number Diff line
@@ -824,6 +824,10 @@ void AudioFlinger::PlaybackThread::Track::flush() 
            // remove from active track list, reset(), and trigger presentation complete

            if (playbackThread->mActiveTracks.indexOf(this) < 0) {

                reset();

                if (thread->type() == ThreadBase::DIRECT) {

                    DirectOutputThread *t = (DirectOutputThread *)playbackThread;

                    t->flushHw_l();

                }

            }

        }

        // Prevent flush being lost if the track is flushed and then resumed