Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e52953ef authored by Mårten Kongstad's avatar Mårten Kongstad
Browse files

Mark @FlaggedApi flags as exported 

An aconfig flag that is used together with @FlaggedApi must be marked as
`is_exported: true` to guarantee that the auto-generated lookup code
checks the actual flag value (instead of using a hard-coded value set at
compile time). This is important when the API is called across aconfig
container boundaries (e.g. a mainline module calling code on the system
partition).

Mark all non-exported flags used with @FlaggedApi as exported.

The "all @FlaggedApi flags are exported" invariant should be checked at
build time; this will be added in future CLs.

Bug: 378061535
Test: treehugger
Flag: EXEMPT can't flag changes to flag declarations
Change-Id: I6dd6d526044660b8375cad52af8972f0bdf353eb
parent f76f57f1

media/aconfig/codec_fwk.aconfig

+2 −0
Original line number Diff line number Diff line
@@ -130,6 +130,7 @@ flag { 
  namespace: "codec_fwk"

  description: "Feature flag for exposing number of input slots"

  bug: "159891571"

  is_exported: true

}



flag {
@@ -207,6 +208,7 @@ flag { 
  namespace: "codec_fwk"

  description: "Feature flag for subsession codec metrics"

  bug: "363382811"

  is_exported: true

}



flag {

media/aconfig/mediacodec_flags.aconfig

+1 −0
Original line number Diff line number Diff line
@@ -26,4 +26,5 @@ flag { 
  namespace: "codec_fwk"

  description: "Feature flags for large audio frame support"

  bug: "297219557"

  is_exported: true

}

media/audio/aconfig/audio_framework.aconfig

+7 −0
Original line number Diff line number Diff line
@@ -30,6 +30,7 @@ flag { 
       "New privileged permission to allow bypassing concurrent audio"

       "capture rules."

    bug: "374751406"

    is_exported: true

}



flag {
@@ -82,6 +83,7 @@ flag { 
    description: "Feature flag for Dolby AC-4 level 4 AudioFormat encoding."

    is_fixed_read_only: true

    bug: "266537650"

    is_exported: true

}



# TODO remove
@@ -158,6 +160,7 @@ flag { 
    namespace: "media_audio"

    description: "Playback monitoring flag used when player muted by port volume"

    bug: "319515324"

    is_exported: true

}



flag {
@@ -204,6 +207,7 @@ flag { 
        "Enable Java and native functions to get"

        "multiple routed device ids"

    bug: "367816690"

    is_exported: true

}



flag {
@@ -218,6 +222,7 @@ flag { 
    namespace: "media_audio"

    description: "spatializer reports effective channel masks"

    bug: "377582613"

    is_exported: true

}



flag {
@@ -225,6 +230,7 @@ flag { 
    namespace: "media_audio"

    description: "Support new AudioAttributes usage for speaker cleanup"

    bug: "355050846"

    is_exported: true

}



flag {
@@ -232,6 +238,7 @@ flag { 
    namespace: "media_audio"

    description: "Surface new API method for returning speaker layout channel mask for devices"

    bug: "337522902"

    is_exported: true

}



# TODO remove