Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e4f113b2 authored by Jean-Michel Trivi's avatar Jean-Michel Trivi
Browse files

AudioPolicy/Flinger: harden security checks 

Update list of methods which can only be called from system
components.

Bug: 162423060
Test: see poc
Change-Id: Ie266a2fdd31bdcecfe9c116596ae65a789b812c6
parent f4e0a07d

media/libaudioclient/IAudioPolicyService.cpp

+9 −0
Original line number Diff line number Diff line
@@ -1591,6 +1591,7 @@ status_t BnAudioPolicyService::onTransact( 
        case REGISTER_EFFECT:

        case UNREGISTER_EFFECT:

        case SET_EFFECT_ENABLED:

        case GET_STRATEGY_FOR_STREAM:

        case GET_OUTPUT_FOR_ATTR:

        case MOVE_EFFECTS_TO_IO:

            ALOGW("%s: transaction %d received from PID %d",
@@ -1619,6 +1620,14 @@ status_t BnAudioPolicyService::onTransact( 
        case INIT_STREAM_VOLUME:

        case SET_STREAM_VOLUME:

        case SET_VOLUME_ATTRIBUTES:

        case GET_STREAM_VOLUME:

        case GET_VOLUME_ATTRIBUTES:

        case GET_MIN_VOLUME_FOR_ATTRIBUTES:

        case GET_MAX_VOLUME_FOR_ATTRIBUTES:

        case IS_STREAM_ACTIVE:

        case IS_STREAM_ACTIVE_REMOTELY:

        case IS_SOURCE_ACTIVE:

        case GET_DEVICES_FOR_STREAM:

        case REGISTER_POLICY_MIXES:

        case SET_MASTER_MONO:

        case GET_SURROUND_FORMATS:

services/audioflinger/AudioFlinger.cpp

+1 −0
Original line number Diff line number Diff line
@@ -4092,6 +4092,7 @@ status_t AudioFlinger::onPreTransact( 
    switch (code) {

        case TransactionCode::SET_MASTER_VOLUME:

        case TransactionCode::SET_MASTER_MUTE:

        case TransactionCode::MASTER_MUTE:

        case TransactionCode::SET_MODE:

        case TransactionCode::SET_MIC_MUTE:

        case TransactionCode::SET_LOW_RAM_DEVICE: