Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e450fc53 authored by Daichi Hirono's avatar Daichi Hirono Committed by Android (Google) Code Review
Browse files

Merge "Revert "Return parameters of event as well as event code.""

parents c24e5aed f88ce2d8
Loading
Loading
Loading
Loading
+3 −7
Original line number Diff line number Diff line
@@ -866,19 +866,15 @@ int MtpDevice::submitEventRequest() {
    return currentHandle;
}

int MtpDevice::reapEventRequest(int handle, uint32_t (*parameters)[3]) {
int MtpDevice::reapEventRequest(int handle) {
    Mutex::Autolock autoLock(mEventMutex);
    if (!mProcessingEvent || mCurrentEventHandle != handle || !parameters) {
    if (!mProcessingEvent || mCurrentEventHandle != handle) {
        return -1;
    }
    mProcessingEvent = false;
    const int readSize = mEventPacket.readResponse(mRequestIntr->dev);
    const int result = mEventPacket.getEventCode();
    // MTP event has three parameters.
    (*parameters)[0] = mEventPacket.getParameter(1);
    (*parameters)[1] = mEventPacket.getParameter(2);
    (*parameters)[2] = mEventPacket.getParameter(3);
    return readSize != 0 ? result : 0;
    return readSize == 0 ? 0 : result;
}

void MtpDevice::discardEventRequest(int handle) {
+2 −3
Original line number Diff line number Diff line
@@ -124,9 +124,8 @@ public:
    int                     submitEventRequest();
    // Waits for MTP event from the device and returns MTP event code. It blocks the current thread
    // until it receives an event from the device. |handle| should be a request handle returned
    // by |submitEventRequest|. The function writes event parameters to |parameters|. Returns 0 for
    // cancellations. Returns -1 for errors.
    int                     reapEventRequest(int handle, uint32_t (*parameters)[3]);
    // by |submitEventRequest|. Returns 0 for cancellations. Returns -1 for errors.
    int                     reapEventRequest(int handle);
    // Cancels an event request. |handle| should be request handle returned by
    // |submitEventRequest|. If there is a thread blocked by |reapEventRequest| with the same
    // |handle|, the thread will resume.