Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e028aed5 authored by Mikhail Naganov's avatar Mikhail Naganov
Browse files

Rename AudioGain.useInChannelMask -> isInput 

This is done for consistency with other data structures
and conversion functions.

Bug: 188932434
Test: atest audiofoundation_parcelable_test
Change-Id: I201d7a814dccf74b327f1fbb420a0a96b7c165d2
parent 9dec7011

media/libaudioclient/AidlConversion.cpp

+2 −2
Original line number Diff line number Diff line
@@ -2777,7 +2777,7 @@ aidl2legacy_AudioGain_audio_gain(const media::AudioGain& aidl) { 
    audio_gain legacy;

    legacy.mode = VALUE_OR_RETURN(aidl2legacy_int32_t_audio_gain_mode_t_mask(aidl.mode));

    legacy.channel_mask = VALUE_OR_RETURN(aidl2legacy_AudioChannelLayout_audio_channel_mask_t(

                    aidl.channelMask, aidl.useInChannelMask));

                    aidl.channelMask, aidl.isInput));

    legacy.min_value = VALUE_OR_RETURN(convertIntegral<int>(aidl.minValue));

    legacy.max_value = VALUE_OR_RETURN(convertIntegral<int>(aidl.maxValue));

    legacy.default_value = VALUE_OR_RETURN(convertIntegral<int>(aidl.defaultValue));
@@ -2791,7 +2791,7 @@ ConversionResult<media::AudioGain> 
legacy2aidl_audio_gain_AudioGain(const audio_gain& legacy, bool isInput) {

    media::AudioGain aidl;

    aidl.mode = VALUE_OR_RETURN(legacy2aidl_audio_gain_mode_t_int32_t_mask(legacy.mode));

    aidl.useInChannelMask = isInput;

    aidl.isInput = isInput;

    aidl.channelMask = VALUE_OR_RETURN(

            legacy2aidl_audio_channel_mask_t_AudioChannelLayout(legacy.channel_mask, isInput));

    aidl.minValue = VALUE_OR_RETURN(convertIntegral<int32_t>(legacy.min_value));

media/libaudioclient/aidl/android/media/AudioGain.aidl

+1 −1
Original line number Diff line number Diff line
@@ -23,7 +23,7 @@ import android.media.AudioChannelLayout; 
 */

parcelable AudioGain {

    int index;

    boolean useInChannelMask;

    boolean isInput;

    boolean useForVolume;

    /** Bitmask, indexed by AudioGainMode. */

    int mode;

media/libaudiofoundation/AudioGain.cpp

+13 −19
Original line number Diff line number Diff line
@@ -34,10 +34,10 @@ 


namespace android {



AudioGain::AudioGain(int index, bool useInChannelMask)

AudioGain::AudioGain(int index, bool isInput)

{

    mIndex = index;

    mUseInChannelMask = useInChannelMask;

    mIsInput = isInput;

    memset(&mGain, 0, sizeof(struct audio_gain));

}
@@ -49,12 +49,9 @@ void AudioGain::getDefaultConfig(struct audio_gain_config *config) 
    if ((mGain.mode & AUDIO_GAIN_MODE_JOINT) == AUDIO_GAIN_MODE_JOINT) {

        config->values[0] = mGain.default_value;

    } else {

        uint32_t numValues;

        if (mUseInChannelMask) {

            numValues = audio_channel_count_from_in_mask(mGain.channel_mask);

        } else {

            numValues = audio_channel_count_from_out_mask(mGain.channel_mask);

        }

        const uint32_t numValues = mIsInput ?

                audio_channel_count_from_in_mask(mGain.channel_mask) :

                audio_channel_count_from_out_mask(mGain.channel_mask);

        for (size_t i = 0; i < numValues; i++) {

            config->values[i] = mGain.default_value;

        }
@@ -78,12 +75,9 @@ status_t AudioGain::checkConfig(const struct audio_gain_config *config) 
        if ((config->channel_mask & ~mGain.channel_mask) != 0) {

            return BAD_VALUE;

        }

        uint32_t numValues;

        if (mUseInChannelMask) {

            numValues = audio_channel_count_from_in_mask(config->channel_mask);

        } else {

            numValues = audio_channel_count_from_out_mask(config->channel_mask);

        }

        const uint32_t numValues = mIsInput ?

                audio_channel_count_from_in_mask(config->channel_mask) :

                audio_channel_count_from_out_mask(config->channel_mask);

        for (size_t i = 0; i < numValues; i++) {

            if ((config->values[i] < mGain.min_value) ||

                    (config->values[i] > mGain.max_value)) {
@@ -116,7 +110,7 @@ void AudioGain::dump(std::string *dst, int spaces, int index) const 
bool AudioGain::equals(const sp<AudioGain>& other) const

{

    return other != nullptr &&

           mUseInChannelMask == other->mUseInChannelMask &&

           mIsInput == other->mIsInput &&

           mUseForVolume == other->mUseForVolume &&

           // Compare audio gain

           mGain.mode == other->mGain.mode &&
@@ -137,13 +131,13 @@ status_t AudioGain::writeToParcel(android::Parcel *parcel) const { 


status_t AudioGain::writeToParcelable(media::AudioGain* parcelable) const {

    parcelable->index = VALUE_OR_RETURN_STATUS(convertIntegral<int32_t>(mIndex));

    parcelable->useInChannelMask = mUseInChannelMask;

    parcelable->isInput = mIsInput;

    parcelable->useForVolume = mUseForVolume;

    parcelable->mode = VALUE_OR_RETURN_STATUS(

            legacy2aidl_audio_gain_mode_t_int32_t_mask(mGain.mode));

    parcelable->channelMask = VALUE_OR_RETURN_STATUS(

            legacy2aidl_audio_channel_mask_t_AudioChannelLayout(

                    mGain.channel_mask, mUseInChannelMask));

                    mGain.channel_mask, mIsInput));

    parcelable->minValue = VALUE_OR_RETURN_STATUS(convertIntegral<int32_t>(mGain.min_value));

    parcelable->maxValue = VALUE_OR_RETURN_STATUS(convertIntegral<int32_t>(mGain.max_value));

    parcelable->defaultValue = VALUE_OR_RETURN_STATUS(
@@ -162,13 +156,13 @@ status_t AudioGain::readFromParcel(const android::Parcel *parcel) { 


status_t AudioGain::readFromParcelable(const media::AudioGain& parcelable) {

    mIndex = VALUE_OR_RETURN_STATUS(convertIntegral<int>(parcelable.index));

    mUseInChannelMask = parcelable.useInChannelMask;

    mIsInput = parcelable.isInput;

    mUseForVolume = parcelable.useForVolume;

    mGain.mode = VALUE_OR_RETURN_STATUS(

            aidl2legacy_int32_t_audio_gain_mode_t_mask(parcelable.mode));

    mGain.channel_mask = VALUE_OR_RETURN_STATUS(

            aidl2legacy_AudioChannelLayout_audio_channel_mask_t(

                    parcelable.channelMask, parcelable.useInChannelMask));

                    parcelable.channelMask, parcelable.isInput));

    mGain.min_value = VALUE_OR_RETURN_STATUS(convertIntegral<int>(parcelable.minValue));

    mGain.max_value = VALUE_OR_RETURN_STATUS(convertIntegral<int>(parcelable.maxValue));

    mGain.default_value = VALUE_OR_RETURN_STATUS(convertIntegral<int>(parcelable.defaultValue));

media/libaudiofoundation/include/media/AudioGain.h

+2 −2
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ namespace android { 
class AudioGain: public RefBase, public Parcelable

{

public:

    AudioGain(int index, bool useInChannelMask);

    AudioGain(int index, bool isInput);

    virtual ~AudioGain() {}



    void setMode(audio_gain_mode_t mode) { mGain.mode = mode; }
@@ -80,7 +80,7 @@ public: 
private:

    int               mIndex;

    struct audio_gain mGain;

    bool              mUseInChannelMask;

    bool              mIsInput;

    bool              mUseForVolume = false;

};

media/libaudiofoundation/tests/audiofoundation_parcelable_test.cpp

+1 −1
Original line number Diff line number Diff line
@@ -53,7 +53,7 @@ public: 


AudioGains getAudioGainsForTest() {

    AudioGains audioGains;

    sp<AudioGain> audioGain = new AudioGain(0 /*index*/, false /*useInChannelMask*/);

    sp<AudioGain> audioGain = new AudioGain(0 /*index*/, false /*isInput*/);

    audioGain->setMode(AUDIO_GAIN_MODE_JOINT);

    audioGain->setChannelMask(AUDIO_CHANNEL_OUT_STEREO);

    audioGain->setMinValueInMb(-3200);