Merge "audio effects: filter reserved effect commands" into klp-dev (dc2efe38) · Commits · e / os / android_frameworks_av

services/audioflinger/Effects.cpp

+18 −0

Original line number	Diff line number	Diff line
		@@ -1145,6 +1145,24 @@ status_t AudioFlinger::EffectHandle::command(uint32_t cmdCode,
		ALOGVV("command(), cmdCode: %d, mHasControl: %d, mEffect: %p",
		cmdCode, mHasControl, mEffect.unsafe_get());

		// reject commands reserved for internal use by audio framework if coming from outside
		// of audioserver
		switch(cmdCode) {
		case EFFECT_CMD_ENABLE:
		case EFFECT_CMD_DISABLE:
		case EFFECT_CMD_SET_PARAM:
		case EFFECT_CMD_SET_PARAM_DEFERRED:
		case EFFECT_CMD_SET_PARAM_COMMIT:
		case EFFECT_CMD_GET_PARAM:
		break;
		default:
		if (cmdCode >= EFFECT_CMD_FIRST_PROPRIETARY) {
		break;
		}
		android_errorWriteLog(0x534e4554, "62019992");
		return BAD_VALUE;
		}

		if (cmdCode == EFFECT_CMD_ENABLE) {
		if (*replySize < sizeof(int)) {
		android_errorWriteLog(0x534e4554, "32095713");