Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d863eff9 authored by David Williams's avatar David Williams Committed by Gerrit Code Review
Browse files

Avoid memory leaks when handling metadata strings 

Don't duplicate strings when retrieveing metadata from media
files. As any requests for metadata strings would pass through
the binder, this would cause the reference to the duplicate string
to be lost, causing a memory leak as the duplicate would not be
freed.

Change-Id: I2593733472b1bb589bc502b2c11080f581015bb5
parent 7013209c

media/libstagefright/StagefrightMetadataRetriever.cpp

+1 −1
Original line number Diff line number Diff line
@@ -433,7 +433,7 @@ const char *StagefrightMetadataRetriever::extractMetadata(int keyCode) { 
        return NULL;

    }



    return strdup(mMetaData.valueAt(index).string());

    return mMetaData.valueAt(index).string();

}



void StagefrightMetadataRetriever::parseMetaData() {