Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d6e59e88 authored by Ravneet Dhanjal's avatar Ravneet Dhanjal Committed by Android (Google) Code Review
Browse files

Merge "Camera: Remove tid and pid from abort message" into udc-dev

parents b1a986cb 6245591a

services/camera/libcameraservice/CameraServiceWatchdog.cpp

+3 −5
Original line number Original line Diff line number Diff line
@@ -43,8 +43,7 @@ bool CameraServiceWatchdog::threadLoop() 
            mTidMap[currentThreadId].cycles++;

            mTidMap[currentThreadId].cycles++;





            if (mTidMap[currentThreadId].cycles >= mMaxCycles) {

            if (mTidMap[currentThreadId].cycles >= mMaxCycles) {

                std::string abortMessage = getAbortMessage(getpid(), currentThreadId,

                std::string abortMessage = getAbortMessage(mTidMap[currentThreadId].functionName);

                        mTidMap[currentThreadId].functionName);

                android_set_abort_message(abortMessage.c_str());

                android_set_abort_message(abortMessage.c_str());

                ALOGW("CameraServiceWatchdog triggering abort for pid: %d tid: %d", getpid(),

                ALOGW("CameraServiceWatchdog triggering abort for pid: %d tid: %d", getpid(),

                        currentThreadId);

                        currentThreadId);
@@ -60,10 +59,9 @@ bool CameraServiceWatchdog::threadLoop() 
    return true;

    return true;

}

}





std::string CameraServiceWatchdog::getAbortMessage(int pid, int tid, std::string functionName) {

std::string CameraServiceWatchdog::getAbortMessage(const std::string& functionName) {

    std::string res = "CameraServiceWatchdog triggering abort during "

    std::string res = "CameraServiceWatchdog triggering abort during "

            + functionName + " | pid: " + std::to_string(pid)

            + functionName;

            + " tid: " + std::to_string(tid);

    return res;

    return res;

}

}

services/camera/libcameraservice/CameraServiceWatchdog.h

+1 −1
Original line number Original line Diff line number Diff line
@@ -144,7 +144,7 @@ private: 
     */

     */

    void stop(uint32_t tid);

    void stop(uint32_t tid);





    std::string getAbortMessage(int pid, int tid, std::string functionName);

    std::string getAbortMessage(const std::string& functionName);





    virtual bool    threadLoop();

    virtual bool    threadLoop();