Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d6a604e0 authored by Qiang Chen's avatar Qiang Chen Committed by Huang, Yidong
Browse files

libaudiohal: do not erase port configs if resetting fails 

If the resetAudioPortConfig() returns failure, do not erase its
port configs in AIDL. Otherwise, the config of the framework and
HAL will not match, and the audio patch will never be reset properly.

Bug: 348099828
Test: repro steps from the bug
Change-Id: I69ba25bc84baff1d1f2d11533ab8bbe2c7bb0889
parent 37e9203e

media/libaudiohal/impl/Hal2AidlMapper.cpp

+1 −0
Original line number Diff line number Diff line
@@ -914,6 +914,7 @@ void Hal2AidlMapper::resetPortConfig(int32_t portConfigId) { 
                !status.isOk()) {

            ALOGE("%s: error while resetting port config %d: %s",

                    __func__, portConfigId, status.getDescription().c_str());

            return;

        }

        mPortConfigs.erase(it);

        return;