Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d01cc80e authored by Marco Nelissen's avatar Marco Nelissen
Browse files

Don't use sp<>& 

because they may end up pointing to NULL after a NULL check was performed.

Bug: 28166152
Change-Id: Iab2ea30395b620628cc6f3d067dd4f6fcda824fe
parent edf89fa6

include/media/IMediaDeathNotifier.h

+1 −1
Original line number Diff line number Diff line
@@ -30,7 +30,7 @@ public: 
    virtual ~IMediaDeathNotifier() { removeObitRecipient(this); }



    virtual void died() = 0;

    static const sp<IMediaPlayerService>& getMediaPlayerService();

    static const sp<IMediaPlayerService> getMediaPlayerService();



private:

    IMediaDeathNotifier &operator=(const IMediaDeathNotifier &);

media/libmedia/IMediaDeathNotifier.cpp

+1 −1
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ sp<IMediaDeathNotifier::DeathNotifier> IMediaDeathNotifier::sDeathNotifier; 
SortedVector< wp<IMediaDeathNotifier> > IMediaDeathNotifier::sObitRecipients;



// establish binder interface to MediaPlayerService

/*static*/const sp<IMediaPlayerService>&

/*static*/const sp<IMediaPlayerService>

IMediaDeathNotifier::getMediaPlayerService()

{

    ALOGV("getMediaPlayerService");

media/libmedia/mediaplayer.cpp

+3 −3
Original line number Diff line number Diff line
@@ -149,7 +149,7 @@ status_t MediaPlayer::setDataSource( 
    ALOGV("setDataSource(%s)", url);

    status_t err = BAD_VALUE;

    if (url != NULL) {

        const sp<IMediaPlayerService>& service(getMediaPlayerService());

        const sp<IMediaPlayerService> service(getMediaPlayerService());

        if (service != 0) {

            sp<IMediaPlayer> player(service->create(this, mAudioSessionId));

            if ((NO_ERROR != doSetRetransmitEndpoint(player)) ||
@@ -166,7 +166,7 @@ status_t MediaPlayer::setDataSource(int fd, int64_t offset, int64_t length) 
{

    ALOGV("setDataSource(%d, %" PRId64 ", %" PRId64 ")", fd, offset, length);

    status_t err = UNKNOWN_ERROR;

    const sp<IMediaPlayerService>& service(getMediaPlayerService());

    const sp<IMediaPlayerService> service(getMediaPlayerService());

    if (service != 0) {

        sp<IMediaPlayer> player(service->create(this, mAudioSessionId));

        if ((NO_ERROR != doSetRetransmitEndpoint(player)) ||
@@ -182,7 +182,7 @@ status_t MediaPlayer::setDataSource(const sp<IStreamSource> &source) 
{

    ALOGV("setDataSource");

    status_t err = UNKNOWN_ERROR;

    const sp<IMediaPlayerService>& service(getMediaPlayerService());

    const sp<IMediaPlayerService> service(getMediaPlayerService());

    if (service != 0) {

        sp<IMediaPlayer> player(service->create(this, mAudioSessionId));

        if ((NO_ERROR != doSetRetransmitEndpoint(player)) ||

media/libmedia/mediarecorder.cpp

+1 −1
Original line number Diff line number Diff line
@@ -624,7 +624,7 @@ MediaRecorder::MediaRecorder() : mSurfaceMediaSource(NULL) 
{

    ALOGV("constructor");



    const sp<IMediaPlayerService>& service(getMediaPlayerService());

    const sp<IMediaPlayerService> service(getMediaPlayerService());

    if (service != NULL) {

        mMediaRecorder = service->createMediaRecorder();

    }