Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc8d4f8f authored by Eino-Ville Talvala's avatar Eino-Ville Talvala
Browse files

Camera3: Register all stream buffers at stream configuration time. 

While registering them later would be nice for startup time, current
hardware will have to reinitialize everything, resulting in glitches.

Bug: 8657740
Change-Id: I1ed1f0a65d648f219f5228c8df15ffcf2a4b272e
parent d090054d

services/camera/libcameraservice/Camera3Device.cpp

+22 −0
Original line number Diff line number Diff line
@@ -907,6 +907,28 @@ status_t Camera3Device::configureStreamsLocked() { 
        return res;

    }



    // Finish all stream configuration immediately.

    // TODO: Try to relax this later back to lazy completion, which should be

    // faster



    if (mInputStream != NULL) {

        res = mInputStream->finishConfiguration(mHal3Device);

        if (res != OK) {

            SET_ERR_L("Can't finish configuring input stream %d: %s (%d)",

                    mInputStream->getId(), strerror(-res), res);

            return res;

        }

    }



    for (size_t i = 0; i < mOutputStreams.size(); i++) {

        res = mOutputStreams.editValueAt(i)->finishConfiguration(mHal3Device);

        if (res != OK) {

            SET_ERR_L("Can't finish configuring output stream %d: %s (%d)",

                    mOutputStreams[i]->getId(), strerror(-res), res);

            return res;

        }

    }



    // Request thread needs to know to avoid using repeat-last-settings protocol

    // across configure_streams() calls

    mRequestThread->configurationComplete();