Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c866568d authored by Manisha Jajoo's avatar Manisha Jajoo
Browse files

WriterTest: handle asserts in getInputBufferInfo() 

ASSERT_*() calls in getInbufBUfferInfo() weren't resulting in test failures earlier

Also added a sanity check for MediaAdapter allocation failure

Test: atest writerTest -- --enable-module-dynamic-download=true

Bug: 150181503

Change-Id: I600ab1e7cbbd6d5e508efbf85c3a40753ca14a18
parent 550fef91

media/libstagefright/tests/writer/WriterTest.cpp

+7 −3
Original line number Diff line number Diff line
@@ -243,6 +243,10 @@ int32_t WriterTest::addWriterSource(bool isAudio, configFormat params) { 
    sp<MetaData> trackMeta = new MetaData;

    convertMessageToMetaData(format, trackMeta);

    mCurrentTrack = new MediaAdapter(trackMeta);

    if (mCurrentTrack == nullptr) {

        ALOGE("MediaAdapter returned nullptr");

        return -1;

    }

    status_t result = mWriter->addSource(mCurrentTrack);

    return result;

}
@@ -301,7 +305,7 @@ TEST_P(WriterTest, WriterTest) { 
    getFileDetails(inputFile, inputInfo, param, isAudio, inputFileIdx);

    ASSERT_NE(inputFile.compare(gEnv->getRes()), 0) << "No input file specified";



    getInputBufferInfo(inputFile, inputInfo);

    ASSERT_NO_FATAL_FAILURE(getInputBufferInfo(inputFile, inputInfo));

    status = addWriterSource(isAudio, param);

    ASSERT_EQ((status_t)OK, status) << "Failed to add source for " << writerFormat << "Writer";
@@ -338,7 +342,7 @@ TEST_P(WriterTest, PauseWriterTest) { 
    getFileDetails(inputFile, inputInfo, param, isAudio, inputFileIdx);

    ASSERT_NE(inputFile.compare(gEnv->getRes()), 0) << "No input file specified";



    getInputBufferInfo(inputFile, inputInfo);

    ASSERT_NO_FATAL_FAILURE(getInputBufferInfo(inputFile, inputInfo));

    status = addWriterSource(isAudio, param);

    ASSERT_EQ((status_t)OK, status) << "Failed to add source for " << writerFormat << "Writer";
@@ -397,7 +401,7 @@ TEST_P(WriterTest, MultiStartStopPauseTest) { 
    getFileDetails(inputFile, inputInfo, param, isAudio, inputFileIdx);

    ASSERT_NE(inputFile.compare(gEnv->getRes()), 0) << "No input file specified";



    getInputBufferInfo(inputFile, inputInfo);

    ASSERT_NO_FATAL_FAILURE(getInputBufferInfo(inputFile, inputInfo));

    status = addWriterSource(isAudio, param);

    ASSERT_EQ((status_t)OK, status) << "Failed to add source for " << writerFormat << "Writer";