Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c838f6de authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Android (Google) Code Review
Browse files

Merge "Check opaque size in CREATE_PLUGIN."

parents 997a192b 9247e105
Loading
Loading
Loading
Loading
+11 −7
Original line number Diff line number Diff line
@@ -235,17 +235,21 @@ status_t BnCrypto::onTransact(
            size_t opaqueSize = data.readInt32();
            void *opaqueData = NULL;

            if (opaqueSize > 0) {
            const size_t kMaxOpaqueSize = 100 * 1024;
            if (opaqueSize > kMaxOpaqueSize) {
                return BAD_VALUE;
            }

            opaqueData = malloc(opaqueSize);
                data.read(opaqueData, opaqueSize);
            if (NULL == opaqueData) {
                return NO_MEMORY;
            }

            data.read(opaqueData, opaqueSize);
            reply->writeInt32(createPlugin(uuid, opaqueData, opaqueSize));

            if (opaqueData != NULL) {
            free(opaqueData);
            opaqueData = NULL;
            }

            return OK;
        }