Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c778e593 authored by Mikhail Naganov's avatar Mikhail Naganov
Browse files

audioflinger: Fix crash in EffectChain::dump 

Check for null buffer in dumpInOutBuffer

Bug: 34691158
Change-Id: I5d11fcb1ce0170da7a742fdbe42a7eaeba4370fe
Test: try bug repro steps
parent c0461f5b

services/audioflinger/Effects.cpp

+3 −1
Original line number Diff line number Diff line
@@ -1942,7 +1942,9 @@ void AudioFlinger::EffectChain::syncHalEffectsState() 


static void dumpInOutBuffer(

        char *dump, size_t dumpSize, bool isInput, EffectBufferHalInterface *buffer) {

    if (buffer->externalData() != nullptr) {

    if (buffer == nullptr) {

        snprintf(dump, dumpSize, "%p", buffer);

    } else if (buffer->externalData() != nullptr) {

        snprintf(dump, dumpSize, "%p -> %p",

                isInput ? buffer->externalData() : buffer->audioBuffer()->raw,

                isInput ? buffer->audioBuffer()->raw : buffer->externalData());