DO NOT MERGE Fix divide by zero am: 2e211d38a3 am: 52e86acf03 (c3c3ae03) · Commits · e / os / android_frameworks_av

media/libstagefright/MPEG4Extractor.cpp

+18 −5

Original line number	Diff line number	Diff line
		@@ -472,7 +472,8 @@ sp<MetaData> MPEG4Extractor::getTrackMetaData(
		} else {
		uint32_t sampleIndex;
		uint32_t sampleTime;
		if (track->sampleTable->findThumbnailSample(&sampleIndex) == OK
		if (track->timescale != 0 &&
		track->sampleTable->findThumbnailSample(&sampleIndex) == OK
		&& track->sampleTable->getMetaDataForSample(
		sampleIndex, NULL /* offset /, NULL / size */,
		&sampleTime) == OK) {
		@@ -886,6 +887,10 @@ status_t MPEG4Extractor::parseChunk(off64_t *offset, int depth) {
		case FOURCC('s', 'c', 'h', 'i'):
		case FOURCC('e', 'd', 't', 's'):
		{
		if (chunk_type == FOURCC('m', 'o', 'o', 'v') && depth != 0) {
		ALOGE("moov: depth %d", depth);
		return ERROR_MALFORMED;
		}
		if (chunk_type == FOURCC('m', 'o', 'o', 'f') && !mMoofFound) {
		// store the offset of the first segment
		mMoofFound = true;
		@@ -914,6 +919,10 @@ status_t MPEG4Extractor::parseChunk(off64_t *offset, int depth) {

		bool isTrack = false;
		if (chunk_type == FOURCC('t', 'r', 'a', 'k')) {
		if (depth != 1) {
		ALOGE("trak: depth %d", depth);
		return ERROR_MALFORMED;
		}
		isTrack = true;

		Track *track = new Track;
		@@ -937,6 +946,10 @@ status_t MPEG4Extractor::parseChunk(off64_t *offset, int depth) {
		while (*offset < stop_offset) {
		status_t err = parseChunk(offset, depth + 1);
		if (err != OK) {
		if (isTrack) {
		mLastTrack->skipTrack = true;
		break;
		}
		return err;
		}
		}
		@@ -1282,10 +1295,6 @@ status_t MPEG4Extractor::parseChunk(off64_t *offset, int depth) {

		case FOURCC('s', 't', 's', 'd'):
		{
		if (chunk_data_size < 8) {
		return ERROR_MALFORMED;
		}

		uint8_t buffer[8];
		if (chunk_data_size < (off64_t)sizeof(buffer)) {
		return ERROR_MALFORMED;
		@@ -1865,6 +1874,10 @@ status_t MPEG4Extractor::parseChunk(off64_t *offset, int depth) {
		{
		*offset += chunk_size;

		if (depth != 1) {
		ALOGE("mvhd: depth %d", depth);
		return ERROR_MALFORMED;
		}
		if (chunk_data_size < 32) {
		return ERROR_MALFORMED;
		}