Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c30f0d8e authored by Ray Essick's avatar Ray Essick
Browse files

skip -1 default values in stagefrightrecorder metrics 

don't emit the -1 (default, unspecified) values for
movie, audio, and video timescale fields in the 'recorder'
mediametrics type.

Bug: 78600173
Test: y
parent b9df1597

media/libmediaplayerservice/StagefrightRecorder.cpp

+7 −4
Original line number Diff line number Diff line
@@ -164,8 +164,11 @@ void StagefrightRecorder::updateMetrics() { 
    mAnalyticsItem->setInt32(kRecorderVideoIframeInterval, mIFramesIntervalSec);

    // TBD mAudioSourceNode = 0;

    // TBD mUse64BitFileOffset = false;

    if (mMovieTimeScale != -1)

        mAnalyticsItem->setInt32(kRecorderMovieTimescale, mMovieTimeScale);

    if (mAudioTimeScale != -1)

        mAnalyticsItem->setInt32(kRecorderAudioTimescale, mAudioTimeScale);

    if (mVideoTimeScale != -1)

        mAnalyticsItem->setInt32(kRecorderVideoTimescale, mVideoTimeScale);

    // TBD mCameraId        = 0;

    // TBD mStartTimeOffsetMs = -1;
@@ -2210,7 +2213,7 @@ status_t StagefrightRecorder::getMaxAmplitude(int *max) { 
}



status_t StagefrightRecorder::getMetrics(Parcel *reply) {

    ALOGD("StagefrightRecorder::getMetrics");

    ALOGV("StagefrightRecorder::getMetrics");



    if (reply == NULL) {

        ALOGE("Null pointer argument");