Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c1d17710 authored by Scott Randolph's avatar Scott Randolph
Browse files

Use explicit .c_str() for hidl_string 

hidl_string no longer will provide an implicit cast to const char* as it
interfers with other expected behaviors of the class.  It now emulated
std::string in requiring a call to .c_str() to get the same behavior.

Bug:  36532780
Test:  Build the tree
Change-Id: I2b7c4d8e530cc1678cd08d77e365c5e560493264
parent 80158939

media/libmedia/omx/1.0/WOmxNode.cpp

+1 −1
Original line number Diff line number Diff line
@@ -411,7 +411,7 @@ Return<void> TWOmxNode::getExtensionIndex( 
        getExtensionIndex_cb _hidl_cb) {

    OMX_INDEXTYPE index;

    Status status = toStatus(mBase->getExtensionIndex(

            parameterName, &index));

            parameterName.c_str(), &index));

    _hidl_cb(status, toRawIndexType(index));

    return Void();

}

media/libstagefright/omx/1.0/Omx.cpp

+2 −2
Original line number Diff line number Diff line
@@ -95,11 +95,11 @@ Return<void> Omx::allocateNode( 
    }



    sp<OMXNodeInstance> instance = new OMXNodeInstance(

            this, new LWOmxObserver(observer), name);

            this, new LWOmxObserver(observer), name.c_str());



    OMX_COMPONENTTYPE *handle;

    OMX_ERRORTYPE err = mMaster->makeComponentInstance(

            name, &OMXNodeInstance::kCallbacks,

            name.c_str(), &OMXNodeInstance::kCallbacks,

            instance.get(), &handle);



    if (err != OMX_ErrorNone) {

media/libstagefright/omx/1.0/WOmxNode.cpp

+1 −1
Original line number Diff line number Diff line
@@ -414,7 +414,7 @@ Return<void> TWOmxNode::getExtensionIndex( 
        getExtensionIndex_cb _hidl_cb) {

    OMX_INDEXTYPE index;

    Status status = toStatus(mBase->getExtensionIndex(

            parameterName, &index));

            parameterName.c_str(), &index));

    _hidl_cb(status, toRawIndexType(index));

    return Void();

}