Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c01ff069 authored by Jayant Chowdhary's avatar Jayant Chowdhary
Browse files

cameraserver: Clarify the relation between frames and buffers in request/returnStreamBuffers. 



Test: N/A

Change-Id: I797808e02a4e9524c92c6a7a9f5670ad168ff6e2
Signed-off-by: default avatarJayant Chowdhary <jchowdhary@google.com>
parent f727b4d9

services/camera/libcameraservice/device3/Camera3OutputUtils.cpp

+8 −0
Original line number Diff line number Diff line
@@ -1211,6 +1211,14 @@ void notify(CaptureOutputStates& states, 
    notify(states, &m);

}



// The buffers requested through this call are not tied to any CaptureRequest in

// particular. They may used by the hal for a particular frame's output buffer

// or for its internal use as well. In the case that the hal does use any buffer

// from the requested list here, for a particular frame's output buffer, the

// buffer will be returned with the processCaptureResult call corresponding to

// the frame. The other buffers will be returned through returnStreamBuffers.

// The buffers returned via returnStreamBuffers will not have a valid

// timestamp(0) and will be dropped by the bufferqueue.

void requestStreamBuffers(RequestBufferStates& states,

        const hardware::hidl_vec<hardware::camera::device::V3_5::BufferRequest>& bufReqs,

        hardware::camera::device::V3_5::ICameraDeviceCallback::requestStreamBuffers_cb _hidl_cb) {