Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit be21e039 authored by Yajun Zeng's avatar Yajun Zeng
Browse files

Fix overflow of rand in ARTPConnection 



without this fix, (rand()*1000)/RAND_MAX is mainly 0.

Change-Id: I48ae940a7b6974b197d81732774c9dcea107bcf1
Signed-off-by: default avatarYajun Zeng <beanz@marvell.com>
parent 3030f344

media/libstagefright/rtsp/ARTPConnection.cpp

+2 −1
Original line number Diff line number Diff line
@@ -117,7 +117,8 @@ void ARTPConnection::MakePortPair( 


    bumpSocketBufferSize(*rtcpSocket);



    unsigned start = (rand() * 1000)/ RAND_MAX + 15550;

    /* rand() * 1000 may overflow int type, use long long */

    unsigned start = (unsigned)((rand()* 1000ll)/RAND_MAX) + 15550;

    start &= ~1;



    for (unsigned port = start; port < 65536; port += 2) {