Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bcd0a04b authored by Mikhail Naganov's avatar Mikhail Naganov
Browse files

libaudiohal: Fix handling of NULL replySize param to Effect::command 

Fix crash when the client passes NULL as 'replySize' for Effect::command.

Bug: 30222631
Change-Id: I015a49ba8c7a3103edfcbf9df39bb32093367a7a
Test: No crash when adjusting "Bass Boost" setting in Play Music
parent 38267b77

media/libaudiohal/EffectHalHidl.cpp

+2 −0
Original line number Diff line number Diff line
@@ -171,6 +171,8 @@ status_t EffectHalHidl::command(uint32_t cmdCode, uint32_t cmdSize, void *pCmdDa 
        hidlData.setToExternal(reinterpret_cast<uint8_t*>(pCmdData), cmdSize);

    }

    status_t status;

    uint32_t replySizeStub = 0;

    if (replySize == nullptr) replySize = &replySizeStub;

    Return<void> ret = mEffect->command(cmdCode, hidlData, *replySize,

            [&](int32_t s, const hidl_vec<uint8_t>& result) {

                status = s;