Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b8a6f890 authored by Jean-Baptiste Théou's avatar Jean-Baptiste Théou Committed by Andy Hung
Browse files

extractors: allow OEM to control output type for WAV/FLAC 



Based on some usecase, outputing in float is not an option.

Should allow a property to select the behavior

Bug: 140952553
Test: NativeDecoderTest#testExtractor
Test: MediaExtractorTest#testFlacIdentity
Change-Id: Idf2bf382f50d12c00a85aa7bb5582fb0439c6ea1
Signed-off-by: default avatarJean-Baptiste Théou <jb@essential.com>
parent c3fa11b6

media/extractors/flac/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -8,6 +8,7 @@ cc_library_shared { 
    ],



    shared_libs: [

        "libbase",

        "libbinder_ndk",

        "liblog",

        "libmediandk",

media/extractors/flac/FLACExtractor.cpp

+3 −1
Original line number Diff line number Diff line
@@ -24,6 +24,7 @@ 
// libFLAC parser

#include "FLAC/stream_decoder.h"



#include <android-base/properties.h>

#include <android/binder_ibinder.h> // for AIBinder_getCallingUid

#include <audio_utils/primitives.h>

#include <media/MediaExtractorPluginApi.h>
@@ -47,7 +48,8 @@ namespace android { 
// (Note: duplicated with WAVExtractor.cpp)

static inline bool shouldExtractorOutputFloat(int bitsPerSample)

{

    return bitsPerSample > 16 && AIBinder_getCallingUid() == AID_MEDIA;

    return bitsPerSample > 16 && AIBinder_getCallingUid() == AID_MEDIA

                              && android::base::GetBoolProperty("media.extractor.float", true);

}



class FLACParser;

media/extractors/wav/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -7,6 +7,7 @@ cc_library_shared { 
    ],



    shared_libs: [

        "libbase",

        "libbinder_ndk",

        "liblog",

        "libmediandk",

media/extractors/wav/WAVExtractor.cpp

+3 −1
Original line number Diff line number Diff line
@@ -20,6 +20,7 @@ 


#include "WAVExtractor.h"



#include <android-base/properties.h>

#include <android/binder_ibinder.h> // for AIBinder_getCallingUid

#include <audio_utils/primitives.h>

#include <media/stagefright/foundation/ADebug.h>
@@ -43,7 +44,8 @@ namespace android { 
// (Note: duplicated with FLACExtractor.cpp)

static inline bool shouldExtractorOutputFloat(int bitsPerSample)

{

    return bitsPerSample > 16 && AIBinder_getCallingUid() == AID_MEDIA;

    return bitsPerSample > 16 && AIBinder_getCallingUid() == AID_MEDIA

                              && android::base::GetBoolProperty("media.extractor.float", true);

}



enum {