Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b821e1d4 authored by Manisha Jajoo's avatar Manisha Jajoo
Browse files

NdkMediaCodec: fix AMediaCodec_configure to keep input format constant. 

Test: Print format before and after configure when running video encoder
Bug: b/194535040

Change-Id: I42fd0f09ead4959e78dd69c18f6df2ab2ffd94f9
parent 0cbbad64

media/ndk/NdkMediaCodec.cpp

+5 −3
Original line number Diff line number Diff line
@@ -412,17 +412,19 @@ media_status_t AMediaCodec_configure( 
        uint32_t flags) {

    sp<AMessage> nativeFormat;

    AMediaFormat_getFormat(format, &nativeFormat);

    ALOGV("configure with format: %s", nativeFormat->debugString(0).c_str());

    // create our shallow copy, so we aren't victim to any later changes.

    sp<AMessage> dupNativeFormat = nativeFormat->dup();

    ALOGV("configure with format: %s", dupNativeFormat->debugString(0).c_str());

    sp<Surface> surface = NULL;

    if (window != NULL) {

        surface = (Surface*) window;

    }



    status_t err = mData->mCodec->configure(nativeFormat, surface,

    status_t err = mData->mCodec->configure(dupNativeFormat, surface,

            crypto ? crypto->mCrypto : NULL, flags);

    if (err != OK) {

        ALOGE("configure: err(%d), failed with format: %s",

              err, nativeFormat->debugString(0).c_str());

              err, dupNativeFormat->debugString(0).c_str());

    }

    return translate_error(err);

}