Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b64ee23a authored by Ray Essick's avatar Ray Essick
Browse files

Remove codec aggregation/summarization 

The aggregation, which tries to collect info for standard deviation,
used a 64-bit counter. But with a 4GB video file, when you square the
bytecount, you quickly run up against the 64 bit limit.
So we won't be aggregating those records any longer on-device.

Bug: 66226775
Test: dumpsys media.metrics -summary, no aggregated codec lines
Change-Id: I7c8347eba3d48dfd3b26916e9eb76de1c129817f
parent ac18a847

services/mediaanalytics/MetricsSummarizerCodec.cpp

+0 −21
Original line number Diff line number Diff line
@@ -36,31 +36,10 @@ 


namespace android {



static const char *codec_ignorable[] = {

    "android.media.mediacodec.bytesin",

    0

};



MetricsSummarizerCodec::MetricsSummarizerCodec(const char *key)

    : MetricsSummarizer(key)

{

    ALOGV("MetricsSummarizerCodec::MetricsSummarizerCodec");

    setIgnorables(codec_ignorable);



}



void MetricsSummarizerCodec::mergeRecord(MediaAnalyticsItem &summation, MediaAnalyticsItem &item) {



    ALOGV("MetricsSummarizerCodec::mergeRecord()");



    int64_t bytesin = 0;

    if (item.getInt64("android.media.mediacodec.bytesin", &bytesin)) {

        ALOGV("found bytesin of %" PRId64, bytesin);

    }

    if (bytesin >= 0) {

        minMaxVar64(summation,"android.media.mediacodec.bytesin", bytesin);

    }

}





} // namespace android

services/mediaanalytics/MetricsSummarizerCodec.h

+0 −2
Original line number Diff line number Diff line
@@ -38,8 +38,6 @@ class MetricsSummarizerCodec : public MetricsSummarizer 
    MetricsSummarizerCodec(const char *key);

    virtual ~MetricsSummarizerCodec() {};



    virtual void mergeRecord(MediaAnalyticsItem &have, MediaAnalyticsItem &incoming);



};



// ----------------------------------------------------------------------------