Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b596c34e authored by ray-cy.lee's avatar ray-cy.lee Committed by Ray-cy Lee
Browse files

CTS error while media dump() 

MediaExtractor should not dump information. CTS is
checking and failing due to the dump.

Change-Id: Ie5bae5de39545dede6da4198240b4f38c50050b7
parent 52afe9d2

media/libmedia/IMediaExtractor.cpp

+16 −7
Original line number Diff line number Diff line
@@ -23,6 +23,7 @@ 


#include <binder/IPCThreadState.h>

#include <binder/Parcel.h>

#include <binder/PermissionCache.h>

#include <media/IMediaExtractor.h>

#include <media/stagefright/MetaData.h>
@@ -272,6 +273,13 @@ void registerMediaExtractor( 


status_t dumpExtractors(int fd, const Vector<String16>&) {

    String8 out;

    const IPCThreadState* ipc = IPCThreadState::self();

    const int pid = ipc->getCallingPid();

    const int uid = ipc->getCallingUid();

    if (!PermissionCache::checkPermission(String16("android.permission.DUMP"), pid, uid)) {

        out.appendFormat("Permission Denial: "

                "can't dump MediaExtractor from pid=%d, uid=%d\n", pid, uid);

    } else {

        out.append("Recent extractors, most recent first:\n");

        {

            Mutex::Autolock lock(sExtractorsLock);
@@ -281,6 +289,7 @@ status_t dumpExtractors(int fd, const Vector<String16>&) { 
                out.append(instance.toString());

            }

        }

    }

    write(fd, out.string(), out.size());

    return OK;

}