Merge "Codec2: Detect and release component if the client process terminates" am: 0b505d421c (b3834848) · Commits · e / os / android_frameworks_av

media/codec2/hidl/1.2/utils/Component.cpp

+31 −0

Original line number	Diff line number	Diff line
		@@ -520,6 +520,37 @@ void Component::initListener(const sp<Component>& self) {
		if (res != C2_OK) {
		mInit = res;
		}

		struct ListenerDeathRecipient : public HwDeathRecipient {
		ListenerDeathRecipient(const wp<Component>& comp)
		: component{comp} {
		}

		virtual void serviceDied(
		uint64_t /* cookie */,
		const wp<::android::hidl::base::V1_0::IBase>& /* who */
		) override {
		auto strongComponent = component.promote();
		if (strongComponent) {
		LOG(INFO) << "Client died ! release the component !!";
		strongComponent->release();
		} else {
		LOG(ERROR) << "Client died ! no component to release !!";
		}
		}

		wp<Component> component;
		};

		mDeathRecipient = new ListenerDeathRecipient(self);
		Return<bool> transStatus = mListener->linkToDeath(
		mDeathRecipient, 0);
		if (!transStatus.isOk()) {
		LOG(ERROR) << "Listener linkToDeath() transaction failed.";
		}
		if (!static_cast<bool>(transStatus)) {
		LOG(DEBUG) << "Listener linkToDeath() call failed.";
		}
		}

		Component::~Component() {

+4 −0

Original line number	Diff line number	Diff line
		@@ -142,6 +142,10 @@ protected:
		friend struct ComponentStore;

		struct Listener;

		using HwDeathRecipient = ::android::hardware::hidl_death_recipient;
		sp<HwDeathRecipient> mDeathRecipient;

		};

		} // namespace utils