Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b28d6117 authored by Jean-Michel Trivi's avatar Jean-Michel Trivi Committed by Android (Google) Code Review
Browse files

Merge "Fix non-offloadable effect creation on offload threads" into nyc-mr1-dev

parents 50671609 773ee957
Loading
Loading
Loading
Loading
+4 −6
Original line number Diff line number Diff line
@@ -1341,12 +1341,10 @@ status_t AudioFlinger::PlaybackThread::checkEffectCompatibility_l(
        }
    } break;
    case OFFLOAD:
        // only offloadable effects on offload thread
        if ((desc->flags & EFFECT_FLAG_OFFLOAD_MASK) != EFFECT_FLAG_OFFLOAD_SUPPORTED) {
            ALOGW("checkEffectCompatibility_l(): non offloadable effect %s created on"
                    " OFFLOAD thread %s", desc->name, mThreadName);
            return BAD_VALUE;
        }
        // nothing actionable on offload threads, if the effect:
        //   - is offloadable: the effect can be created
        //   - is NOT offloadable: the effect should still be created, but EffectHandle::enable()
        //     will take care of invalidating the tracks of the thread
        break;
    case DIRECT:
        // Reject any effect on Direct output threads for now, since the format of