Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b233eaef authored by Jayant Chowdhary's avatar Jayant Chowdhary
Browse files

libcamera2ndk_vendor: stop looper thread on ~ACameraDevice() 



Bug: 135641415

Test: enroll; while(1) auth;

Change-Id: I59c522a0e8827c5990926f0cf7c7960e1cea2e5e
Signed-off-by: default avatarJayant Chowdhary <jchowdhary@google.com>
parent 3bd9e0e1

camera/ndk/ndk_vendor/impl/ACameraDevice.cpp

+10 −0
Original line number Diff line number Diff line
@@ -44,6 +44,16 @@ 


using namespace android;



ACameraDevice::~ACameraDevice() {

    Mutex::Autolock _l(mDevice->mDeviceLock);

    if (mDevice->mCbLooper != nullptr) {

      mDevice->mCbLooper->unregisterHandler(mDevice->mHandler->id());

      mDevice->mCbLooper->stop();

    }

    mDevice->mCbLooper.clear();

    mDevice->mHandler.clear();

}



namespace android {

namespace acam {

camera/ndk/ndk_vendor/impl/ACameraDevice.h

+2 −2
Original line number Diff line number Diff line
@@ -135,6 +135,7 @@ class CameraDevice final : public RefBase { 


  private:

    friend ACameraCaptureSession;

    friend ACameraDevice;



    camera_status_t checkCameraClosedOrErrorLocked() const;
@@ -383,8 +384,7 @@ struct ACameraDevice { 
                  sp<ACameraMetadata> chars) :

            mDevice(new android::acam::CameraDevice(id, cb, std::move(chars), this)) {}



    ~ACameraDevice() {};



    ~ACameraDevice();

    /*******************

     * NDK public APIs *

     *******************/