Camera3: Add ZSL stream support (ae500e53) · Commits · e / os / android_frameworks_av

services/camera/libcameraservice/Android.mk

+1 −0

Original line number	Diff line number	Diff line
		@@ -25,6 +25,7 @@ LOCAL_SRC_FILES:= \
		camera2/JpegCompressor.cpp \
		camera2/CaptureSequencer.cpp \
		camera2/ProFrameProcessor.cpp \
		camera2/ZslProcessor3.cpp \
		camera3/Camera3Stream.cpp \
		camera3/Camera3InputStream.cpp \
		camera3/Camera3OutputStream.cpp \

services/camera/libcameraservice/Camera2Client.cpp

+28 −7

Original line number	Diff line number	Diff line
		@@ -28,6 +28,9 @@
		#include "Camera2Device.h"
		#include "Camera3Device.h"

		#include "camera2/ZslProcessor.h"
		#include "camera2/ZslProcessor3.h"

		#define ALOG1(...) ALOGD_IF(gLogLevel >= 1, __VA_ARGS__);
		#define ALOG2(...) ALOGD_IF(gLogLevel >= 2, __VA_ARGS__);

		@@ -51,12 +54,13 @@ Camera2Client::Camera2Client(const sp<CameraService>& cameraService,
		int deviceVersion):
		Camera2ClientBase(cameraService, cameraClient, clientPackageName,
		cameraId, cameraFacing, clientPid, clientUid, servicePid),
		mParameters(cameraId, cameraFacing)
		mParameters(cameraId, cameraFacing),
		mDeviceVersion(deviceVersion)
		{
		ATRACE_CALL();
		ALOGI("Camera %d: Opened", cameraId);

		switch (deviceVersion) {
		switch (mDeviceVersion) {
		case CAMERA_DEVICE_API_VERSION_2_0:
		mDevice = new Camera2Device(cameraId);
		break;
		@@ -65,7 +69,7 @@ Camera2Client::Camera2Client(const sp<CameraService>& cameraService,
		break;
		default:
		ALOGE("Camera %d: Unknown HAL device version %d",
		cameraId, deviceVersion);
		cameraId, mDeviceVersion);
		mDevice = NULL;
		break;
		}
		@@ -114,10 +118,27 @@ status_t Camera2Client::initialize(camera_module_t *module)
		mCameraId);
		mJpegProcessor->run(threadName.string());

		mZslProcessor = new ZslProcessor(this, mCaptureSequencer);
		switch (mDeviceVersion) {
		case CAMERA_DEVICE_API_VERSION_2_0: {
		sp<ZslProcessor> zslProc =
		new ZslProcessor(this, mCaptureSequencer);
		mZslProcessor = zslProc;
		mZslProcessorThread = zslProc;
		break;
		}
		case CAMERA_DEVICE_API_VERSION_3_0:{
		sp<ZslProcessor3> zslProc =
		new ZslProcessor3(this, mCaptureSequencer);
		mZslProcessor = zslProc;
		mZslProcessorThread = zslProc;
		break;
		}
		default:
		break;
		}
		threadName = String8::format("C2-%d-ZslProc",
		mCameraId);
		mZslProcessor->run(threadName.string());
		mZslProcessorThread->run(threadName.string());

		mCallbackProcessor = new CallbackProcessor(this);
		threadName = String8::format("C2-%d-CallbkProc",
		@@ -393,7 +414,7 @@ void Camera2Client::disconnect() {
		mFrameProcessor->requestExit();
		mCaptureSequencer->requestExit();
		mJpegProcessor->requestExit();
		mZslProcessor->requestExit();
		mZslProcessorThread->requestExit();
		mCallbackProcessor->requestExit();

		ALOGV("Camera %d: Waiting for threads", mCameraId);
		@@ -401,7 +422,7 @@ void Camera2Client::disconnect() {
		mFrameProcessor->join();
		mCaptureSequencer->join();
		mJpegProcessor->join();
		mZslProcessor->join();
		mZslProcessorThread->join();
		mCallbackProcessor->join();

		ALOGV("Camera %d: Disconnecting device", mCameraId);

services/camera/libcameraservice/Camera2Client.h

+4 −2

Original line number	Diff line number	Diff line
		@@ -23,7 +23,7 @@
		#include "camera2/FrameProcessor.h"
		#include "camera2/StreamingProcessor.h"
		#include "camera2/JpegProcessor.h"
		#include "camera2/ZslProcessor.h"
		#include "camera2/ZslProcessorInterface.h"
		#include "camera2/CaptureSequencer.h"
		#include "camera2/CallbackProcessor.h"
		#include "Camera2ClientBase.h"
		@@ -154,6 +154,7 @@ private:

		void setPreviewCallbackFlagL(Parameters &params, int flag);
		status_t updateRequests(Parameters &params);
		int mDeviceVersion;

		// Used with stream IDs
		static const int NO_STREAM = -1;
		@@ -173,7 +174,8 @@ private:

		sp<camera2::CaptureSequencer> mCaptureSequencer;
		sp<camera2::JpegProcessor> mJpegProcessor;
		sp<camera2::ZslProcessor> mZslProcessor;
		sp<camera2::ZslProcessorInterface> mZslProcessor;
		sp<Thread> mZslProcessorThread;

		/** Notification-related members */

services/camera/libcameraservice/Camera3Device.cpp

+87 −2

Original line number	Diff line number	Diff line
		@@ -433,6 +433,81 @@ status_t Camera3Device::createInputStream(
		return OK;
		}


		status_t Camera3Device::createZslStream(
		uint32_t width, uint32_t height,
		int depth,
		/out/
		int *id,
		sp<Camera3ZslStream>* zslStream) {
		ATRACE_CALL();
		Mutex::Autolock l(mLock);

		status_t res;
		bool wasActive = false;

		switch (mStatus) {
		case STATUS_ERROR:
		ALOGE("%s: Device has encountered a serious error", __FUNCTION__);
		return INVALID_OPERATION;
		case STATUS_UNINITIALIZED:
		ALOGE("%s: Device not initialized", __FUNCTION__);
		return INVALID_OPERATION;
		case STATUS_IDLE:
		// OK
		break;
		case STATUS_ACTIVE:
		ALOGV("%s: Stopping activity to reconfigure streams", __FUNCTION__);
		mRequestThread->setPaused(true);
		res = waitUntilDrainedLocked();
		if (res != OK) {
		ALOGE("%s: Can't pause captures to reconfigure streams!",
		__FUNCTION__);
		mStatus = STATUS_ERROR;
		return res;
		}
		wasActive = true;
		break;
		default:
		ALOGE("%s: Unexpected status: %d", __FUNCTION__, mStatus);
		return INVALID_OPERATION;
		}
		assert(mStatus == STATUS_IDLE);

		if (mInputStream != 0) {
		ALOGE("%s: Cannot create more than 1 input stream", __FUNCTION__);
		return INVALID_OPERATION;
		}

		sp<Camera3ZslStream> newStream = new Camera3ZslStream(mNextStreamId,
		width, height, depth);

		res = mOutputStreams.add(mNextStreamId, newStream);
		if (res < 0) {
		ALOGE("%s: Can't add new stream to set: %s (%d)",
		__FUNCTION__, strerror(-res), res);
		return res;
		}
		mInputStream = newStream;

		*id = mNextStreamId++;
		*zslStream = newStream;

		// Continue captures if active at start
		if (wasActive) {
		ALOGV("%s: Restarting activity to reconfigure streams", __FUNCTION__);
		res = configureStreamsLocked();
		if (res != OK) {
		ALOGE("%s: Can't reconfigure device for new stream %d: %s (%d)",
		__FUNCTION__, mNextStreamId, strerror(-res), res);
		return res;
		}
		mRequestThread->setPaused(false);
		}

		return OK;
		}

		status_t Camera3Device::createStream(sp<ANativeWindow> consumer,
		uint32_t width, uint32_t height, int format, size_t size, int *id) {
		ATRACE_CALL();
		@@ -588,7 +663,7 @@ status_t Camera3Device::deleteStream(int id) {
		return INVALID_OPERATION;
		}

		sp<Camera3Stream> deletedStream;
		sp<Camera3StreamInterface> deletedStream;
		if (mInputStream != NULL && id == mInputStream->getId()) {
		deletedStream = mInputStream;
		mInputStream.clear();
		@@ -881,7 +956,8 @@ sp<Camera3Device::CaptureRequest> Camera3Device::createCaptureRequest(
		__FUNCTION__, streams.data.u8[i]);
		return NULL;
		}
		sp<Camera3OutputStream> stream = mOutputStreams.editValueAt(idx);
		sp<Camera3OutputStreamInterface> stream =
		mOutputStreams.editValueAt(idx);

		// Lazy completion of stream configuration (allocation/registration)
		// on first use
		@@ -932,6 +1008,15 @@ status_t Camera3Device::configureStreamsLocked() {
		}

		for (size_t i = 0; i < mOutputStreams.size(); i++) {

		// Don't configure bidi streams twice, nor add them twice to the list
		if (mOutputStreams[i].get() ==
		static_cast<Camera3StreamInterface*>(mInputStream.get())) {

		config.num_streams--;
		continue;
		}

		camera3_stream_t *outputStream;
		outputStream = mOutputStreams.editValueAt(i)->startConfiguration();
		if (outputStream == NULL) {

services/camera/libcameraservice/Camera3Device.h

+12 −3

Original line number	Diff line number	Diff line
		@@ -26,6 +26,7 @@
		#include "CameraDeviceBase.h"
		#include "camera3/Camera3Stream.h"
		#include "camera3/Camera3OutputStream.h"
		#include "camera3/Camera3ZslStream.h"

		#include "hardware/camera3.h"

		@@ -85,6 +86,12 @@ class Camera3Device :
		virtual status_t createInputStream(
		uint32_t width, uint32_t height, int format,
		int *id);
		virtual status_t createZslStream(
		uint32_t width, uint32_t height,
		int depth,
		/out/
		int *id,
		sp<camera3::Camera3ZslStream>* zslStream);
		virtual status_t createReprocessStreamFromStream(int outputId, int *id);

		virtual status_t getStreamInfo(int id,
		@@ -132,14 +139,15 @@ class Camera3Device :
		} mStatus;

		// Mapping of stream IDs to stream instances
		typedef KeyedVector<int, sp<camera3::Camera3OutputStream> > StreamSet;
		typedef KeyedVector<int, sp<camera3::Camera3OutputStreamInterface> >
		StreamSet;

		StreamSet mOutputStreams;
		sp<camera3::Camera3Stream> mInputStream;
		int mNextStreamId;

		// Need to hold on to stream references until configure completes.
		Vector<sp<camera3::Camera3Stream> > mDeletedStreams;
		Vector<sp<camera3::Camera3StreamInterface> > mDeletedStreams;

		/** End scope for mLock **/

		@@ -147,7 +155,8 @@ class Camera3Device :
		public:
		CameraMetadata mSettings;
		sp<camera3::Camera3Stream> mInputStream;
		Vector<sp<camera3::Camera3Stream> > mOutputStreams;
		Vector<sp<camera3::Camera3OutputStreamInterface> >
		mOutputStreams;
		};
		typedef List<sp<CaptureRequest> > RequestList;