Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ab9071b8 authored by Eric Laurent's avatar Eric Laurent
Browse files

audioflinger: fix active sleep time calculation. 

When an audioTrack underruns, the audioflinger mixer thread
sleeps for a certain time to give the app a chance to recover.
This time is based on the reported audio HAL latency.
Some audio HALs implementing deep buffering have a variable
latency and this creates a problem if the sleep time is cached
when the output stream is opened and not updated afterwards.

This change derives the active sleep time from the mix buffer
framecount instead of the latency. This is more conservative
but works for variable latency.

Bug 6588525.

Change-Id: Ia892fc290fe06f836565c3ae15f7a2ce026c88c6
parent 39993085

services/audioflinger/AudioFlinger.cpp

+1 −8
Original line number Diff line number Diff line
@@ -2114,14 +2114,7 @@ audio_stream_t* AudioFlinger::PlaybackThread::stream() const 


uint32_t AudioFlinger::PlaybackThread::activeSleepTimeUs() const

{

    // A2DP output latency is not due only to buffering capacity. It also reflects encoding,

    // decoding and transfer time. So sleeping for half of the latency would likely cause

    // underruns

    if (audio_is_a2dp_device((audio_devices_t)mDevice)) {

    return (uint32_t)((uint32_t)((mNormalFrameCount * 1000) / mSampleRate) * 1000);

    } else {

        return (uint32_t)(mOutput->stream->get_latency(mOutput->stream) * 1000) / 2;

    }

}



status_t AudioFlinger::PlaybackThread::setSyncEvent(const sp<SyncEvent>& event)