Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a994fd09 authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Android (Google) Code Review
Browse files

Merge "Fix UAF in metrics summarizer code"

parents f37a952f de000859
Loading
Loading
Loading
Loading
+2 −6
Original line number Diff line number Diff line
@@ -85,16 +85,12 @@ const char *MetricsSummarizer::getKey() {
// should the record be given to this summarizer
bool MetricsSummarizer::isMine(MediaAnalyticsItem &item)
{
    const char *incoming = item.getKey().c_str();
    if (incoming == NULL) {
        incoming = "unspecified";
    }
    if (mKey == NULL)
        return true;
    if (strcmp(mKey, incoming) != 0) {
    AString itemKey = item.getKey();
    if (strcmp(mKey, itemKey.c_str()) != 0) {
        return false;
    }
    // since nothing failed....
    return true;
}