Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a8c60ccd authored by Saketh Sathuvalli's avatar Saketh Sathuvalli
Browse files

libeffects: Removed void cast related comments that are not relevant 

Void cast related comments for LoadConst_Float function are
not relevant. Removed the same.

Test: Tested using standalone application
Change-Id: Iace5add23c27f8008a3abc9807f141d4985bd1c5
parent bd592dc6

media/libeffects/lvm/lib/Bass/src/LVDBE_Control.cpp

+2 −4
Original line number Diff line number Diff line
@@ -131,8 +131,7 @@ void LVDBE_SetFilters(LVDBE_Instance_t *pInstance, 
                 sizeof(pInstance->pData->HPFTaps)/sizeof(LVM_INT16));   /* Number of words */

#else

    LoadConst_Float(0,                                          /* Clear the history, value 0 */

                   (LVM_FLOAT *)&pInstance->pData->HPFTaps,     /* Destination Cast to void: \

                                                                  no dereferencing in function*/

                   (LVM_FLOAT *)&pInstance->pData->HPFTaps,     /* Destination */

                    sizeof(pInstance->pData->HPFTaps) / sizeof(LVM_FLOAT)); /* Number of words */

#endif

#ifndef BUILD_FLOAT
@@ -156,8 +155,7 @@ void LVDBE_SetFilters(LVDBE_Instance_t *pInstance, 
                 sizeof(pInstance->pData->BPFTaps)/sizeof(LVM_INT16));   /* Number of words */

#else

    LoadConst_Float(0,                                           /* Clear the history, value 0 */

                 (LVM_FLOAT *)&pInstance->pData->BPFTaps,        /* Destination Cast to void: \

                                                                    no dereferencing in function*/

                 (LVM_FLOAT *)&pInstance->pData->BPFTaps,        /* Destination */

                 sizeof(pInstance->pData->BPFTaps) / sizeof(LVM_FLOAT));   /* Number of words */

#endif

#ifndef BUILD_FLOAT

media/libeffects/lvm/lib/Reverb/src/LVREV_ApplyNewSettings.cpp

+2 −4
Original line number Diff line number Diff line
@@ -638,8 +638,7 @@ LVREV_ReturnStatus_en LVREV_ApplyNewSettings (LVREV_Instance_st *pPrivate) 
        FO_1I_D32F32Cll_TRC_WRA_01_Init( &pPrivate->pFastCoef->HPCoefs,

                                         &pPrivate->pFastData->HPTaps, &Coeffs);

        LoadConst_Float(0,

                (LVM_FLOAT *)&pPrivate->pFastData->HPTaps, /* Destination Cast to void: \

                                                                 no dereferencing in function*/

                (LVM_FLOAT *)&pPrivate->pFastData->HPTaps,

                        sizeof(Biquad_1I_Order1_FLOAT_Taps_t) / sizeof(LVM_FLOAT));

    }
@@ -672,8 +671,7 @@ LVREV_ReturnStatus_en LVREV_ApplyNewSettings (LVREV_Instance_st *pPrivate) 
        FO_1I_D32F32Cll_TRC_WRA_01_Init( &pPrivate->pFastCoef->LPCoefs,

                                         &pPrivate->pFastData->LPTaps, &Coeffs);

        LoadConst_Float(0,

                (LVM_FLOAT *)&pPrivate->pFastData->LPTaps, /* Destination Cast to void: \

                                                                 no dereferencing in function*/

                (LVM_FLOAT *)&pPrivate->pFastData->LPTaps,

                        sizeof(Biquad_1I_Order1_FLOAT_Taps_t) / sizeof(LVM_FLOAT));

    }

media/libeffects/lvm/lib/Reverb/src/LVREV_ClearAudioBuffers.cpp

+2 −4
Original line number Diff line number Diff line
@@ -63,12 +63,10 @@ LVREV_ReturnStatus_en LVREV_ClearAudioBuffers(LVREV_Handle_t hInstance) 


#ifdef BUILD_FLOAT

    LoadConst_Float(0,

        (LVM_FLOAT *)&pLVREV_Private->pFastData->HPTaps, /* Destination Cast to void: \

                                                         no dereferencing in function*/

        (LVM_FLOAT *)&pLVREV_Private->pFastData->HPTaps,

        2);

    LoadConst_Float(0,

        (LVM_FLOAT *)&pLVREV_Private->pFastData->LPTaps, /* Destination Cast to void: \

                                                         no dereferencing in function*/

        (LVM_FLOAT *)&pLVREV_Private->pFastData->LPTaps,

        2);

#else

    LoadConst_32(0,

media/libeffects/lvm/lib/StereoWidening/src/LVCS_Equaliser.cpp

+1 −2
Original line number Diff line number Diff line
@@ -92,8 +92,7 @@ LVCS_ReturnStatus_en LVCS_EqualiserInit(LVCS_Handle_t hInstance, 
        Coeffs.B2 = (LVM_FLOAT)-pEqualiserCoefTable[Offset].B2;



        LoadConst_Float((LVM_INT16)0,                                         /* Value */

                        (LVM_FLOAT *)&pData->EqualiserBiquadTaps, /* Destination Cast to void:\

                                                                  no dereferencing in function*/

                        (LVM_FLOAT *)&pData->EqualiserBiquadTaps, /* Destination */

                        /* Number of words */

                        (LVM_UINT16)(sizeof(pData->EqualiserBiquadTaps) / sizeof(LVM_FLOAT)));

media/libeffects/lvm/lib/StereoWidening/src/LVCS_ReverbGenerator.cpp

+1 −2
Original line number Diff line number Diff line
@@ -112,8 +112,7 @@ LVCS_ReturnStatus_en LVCS_ReverbGeneratorInit(LVCS_Handle_t hInstance, 
        Coeffs.B2 = (LVM_FLOAT)-pReverbCoefTable[Offset].B2;



        LoadConst_Float(0,                                 /* Value */

                        (LVM_FLOAT *)&pData->ReverbBiquadTaps,  /* Destination Cast to void:

                                                             no dereferencing in function*/

                        (LVM_FLOAT *)&pData->ReverbBiquadTaps, /* Destination */

                        /* Number of words */

                        (LVM_UINT16)(sizeof(pData->ReverbBiquadTaps) / sizeof(LVM_FLOAT)));