Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a7fd4190 authored by Wonsik Kim's avatar Wonsik Kim
Browse files

stagefright: add nullptr check in MediaCodecSource 

Bug: 183068143
Test: bug repro steps
Change-Id: I53cc2cba1077091faa48b3cd438abd8b160039e8
parent 2f844ad4

media/libstagefright/MediaCodecSource.cpp

+5 −2
Original line number Diff line number Diff line
@@ -715,6 +715,9 @@ void MediaCodecSource::resume(int64_t resumeStartTimeUs) { 
status_t MediaCodecSource::feedEncoderInputBuffers() {

    MediaBufferBase* mbuf = NULL;

    while (!mAvailEncoderInputIndices.empty() && mPuller->readBuffer(&mbuf)) {

        if (!mEncoder) {

            return BAD_VALUE;

        }

        size_t bufferIndex = *mAvailEncoderInputIndices.begin();

        mAvailEncoderInputIndices.erase(mAvailEncoderInputIndices.begin());
@@ -1148,7 +1151,7 @@ void MediaCodecSource::onMessageReceived(const sp<AMessage> &msg) { 
        if (mFlags & FLAG_USE_SURFACE_INPUT) {

            sp<AMessage> params = new AMessage;

            params->setInt64(PARAMETER_KEY_OFFSET_TIME, mInputBufferTimeOffsetUs);

            err = mEncoder->setParameters(params);

            err = mEncoder ? mEncoder->setParameters(params) : BAD_VALUE;

        }



        sp<AMessage> response = new AMessage;
@@ -1168,7 +1171,7 @@ void MediaCodecSource::onMessageReceived(const sp<AMessage> &msg) { 
        if (mFlags & FLAG_USE_SURFACE_INPUT) {

            sp<AMessage> params = new AMessage;

            params->setInt64("stop-time-us", stopTimeUs);

            err = mEncoder->setParameters(params);

            err = mEncoder ? mEncoder->setParameters(params) : BAD_VALUE;

        } else {

            err = mPuller->setStopTimeUs(stopTimeUs);

        }