Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a633bc78 authored by Ricardo Garcia's avatar Ricardo Garcia Committed by Android (Google) Code Review
Browse files

Merge "Fix potential overflow in Visualizer effect"

parents 13f461f9 099ab280

media/libeffects/visualizer/EffectVisualizer.cpp

+9 −0
Original line number Diff line number Diff line
@@ -25,6 +25,7 @@ 
#include <time.h>

#include <math.h>

#include <audio_effects/effect_visualizer.h>

#include <cutils/log.h>





extern "C" {
@@ -599,6 +600,14 @@ int Visualizer_command(effect_handle_t self, uint32_t cmdCode, uint32_t cmdSize, 
        } break;



    case VISUALIZER_CMD_MEASURE: {

        if (pReplyData == NULL || replySize == NULL ||

                *replySize < (sizeof(int32_t) * MEASUREMENT_COUNT)) {

            ALOGV("VISUALIZER_CMD_MEASURE() error *replySize %" PRIu32

                    " < (sizeof(int32_t) * MEASUREMENT_COUNT) %" PRIu32, *replySize,

                    sizeof(int32_t) * MEASUREMENT_COUNT);

            android_errorWriteLog(0x534e4554, "30229821");

            return -EINVAL;

        }

        uint16_t peakU16 = 0;

        float sumRmsSquared = 0.0f;

        uint8_t nbValidMeasurements = 0;