Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a2c05e03 authored by Marco Nelissen's avatar Marco Nelissen Committed by android-build-merger
Browse files

Don't CHECK when buffer is too large am: c2f0c73b am: acb7186e am:... 

Don't CHECK when buffer is too large am: c2f0c73b am: acb7186e am: 0a4db601 am: 8474c51a am: a5333c00 am: 7e5936e6 am: 81341d9c
am: 5a62595e

Change-Id: Ib934e29990941bb7e30196be3ff7b1d67e61b211
parents a59dca66 5a62595e

media/libstagefright/OMXCodec.cpp

+10 −2
Original line number Diff line number Diff line
@@ -2851,7 +2851,11 @@ bool OMXCodec::drainInputBuffer(BufferInfo *info) { 
            static const uint8_t kNALStartCode[4] =

                    { 0x00, 0x00, 0x00, 0x01 };



            CHECK(info->mSize >= specific->mSize + 4);

            if (info->mSize < specific->mSize + 4) {

                ALOGE("info size %zu < specific size %zu", info->mSize, specific->mSize + 4);

                setState(ERROR);

                return false;

            }



            size += 4;
@@ -2859,7 +2863,11 @@ bool OMXCodec::drainInputBuffer(BufferInfo *info) { 
            memcpy((uint8_t *)info->mData + 4,

                   specific->mData, specific->mSize);

        } else {

            CHECK(info->mSize >= specific->mSize);

            if (info->mSize < specific->mSize) {

                ALOGE("info size %zu < specific size %zu", info->mSize, specific->mSize);

                setState(ERROR);

                return false;

            }

            memcpy(info->mData, specific->mData, specific->mSize);

        }