Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a1dee6e3 authored by Sam Hasinoff's avatar Sam Hasinoff Committed by Zhijun He
Browse files

Fix definition of Bayer phase to match DNG SDK

Note that the Adobe DNG 1.4 spec for Bayer phase (defined for the
FixBadPixelsConstant and FixBadPixelsList opcodes) is incorrect. It's
inconsistent with the DNG SDK (cf. dng_negative::SetBayerMosaic and
dng_opcode_FixBadPixelsList::IsGreen), and Adobe confirms that the
spec should be updated to match the SDK.

Test: build
Bug: 78294972
Change-Id: Ie60fb3370b80ed30c8c05505dcfdc873746e244a
parent 58a1c16f
Loading
Loading
Loading
Loading
+8 −3
Original line number Diff line number Diff line
@@ -39,11 +39,16 @@ namespace img_utils {
 */
class ANDROID_API OpcodeListBuilder : public LightRefBase<OpcodeListBuilder> {
    public:
        // Note that the Adobe DNG 1.4 spec for Bayer phase (defined for the
        // FixBadPixelsConstant and FixBadPixelsList opcodes) is incorrect. It's
        // inconsistent with the DNG SDK (cf. dng_negative::SetBayerMosaic and
        // dng_opcode_FixBadPixelsList::IsGreen), and Adobe confirms that the
        // spec should be updated to match the SDK.
        enum CfaLayout {
            CFA_RGGB = 0,
            CFA_GRBG,
            CFA_GBRG,
            CFA_GRBG = 0,
            CFA_RGGB,
            CFA_BGGR,
            CFA_GBRG,
        };

        OpcodeListBuilder();