Commit a0b84960 authored Aug 29, 2017 by George Burgess IV

libcameraservice: fix static analyzer complaints

Due to https://bugs.llvm.org/show_bug.cgi?id=34365, the static analyzer
complains about use of copied `sp`s. In this case, the copy is entirely
unnecessary, since we're just going to destroy the copied-from sp
anyway.

Speed things up a bit + appease the analyzer by moving instead.

Bug: 27101951
Test: mma. Static analyzer no longer complains.
Change-Id: I148212e418cb3f8728383db92b564523525b633a

parent 0fdeb09e

services/camera/libcameraservice/common/CameraProviderManager.cpp

+1 −1

Original line number	Diff line number	Diff line
		@@ -1339,7 +1339,7 @@ status_t HidlVendorTagDescriptor::createDescriptorFromHidl(
		desc->mReverseMapping[reverseIndex]->add(desc->mTagToNameMap.valueFor(tag), tag);
		}

		descriptor = desc;
		descriptor = std::move(desc);
		return OK;
		}