Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a039c883 authored by Chih-Hung Hsieh's avatar Chih-Hung Hsieh
Browse files

Fix google-explict-constructor warnings in mtp. 

* Add explicit keyword to conversion constructors.
Bug: 28341362
Test: build with WITH_TIDY=1

Change-Id: I3a84ae7ffa03b2e23562edef95ef6abefe0ff456
parent 67fbddfd

media/mtp/MtpObjectInfo.h

+1 −1
Original line number Original line Diff line number Diff line
@@ -47,7 +47,7 @@ public: 
    char*               mKeywords;

    char*               mKeywords;





public:

public:

                        MtpObjectInfo(MtpObjectHandle handle);

    explicit            MtpObjectInfo(MtpObjectHandle handle);

    virtual             ~MtpObjectInfo();

    virtual             ~MtpObjectInfo();





    bool                read(MtpDataPacket& packet);

    bool                read(MtpDataPacket& packet);

media/mtp/MtpPacket.h

+1 −1
Original line number Original line Diff line number Diff line
@@ -35,7 +35,7 @@ protected: 
    size_t              mPacketSize;

    size_t              mPacketSize;





public:

public:

                        MtpPacket(int bufferSize);

    explicit            MtpPacket(int bufferSize);

    virtual             ~MtpPacket();

    virtual             ~MtpPacket();





    // sets packet size to the default container size and sets buffer to zero

    // sets packet size to the default container size and sets buffer to zero

media/mtp/MtpStorageInfo.h

+1 −1
Original line number Original line Diff line number Diff line
@@ -36,7 +36,7 @@ public: 
    char*               mVolumeIdentifier;

    char*               mVolumeIdentifier;





public:

public:

                        MtpStorageInfo(MtpStorageID id);

    explicit            MtpStorageInfo(MtpStorageID id);

    virtual             ~MtpStorageInfo();

    virtual             ~MtpStorageInfo();





    bool                read(MtpDataPacket& packet);

    bool                read(MtpDataPacket& packet);

media/mtp/MtpStringBuffer.h

+2 −2
Original line number Original line Diff line number Diff line
@@ -38,8 +38,8 @@ private: 




public:

public:

                    MtpStringBuffer();

                    MtpStringBuffer();

                    MtpStringBuffer(const char* src);

    explicit        MtpStringBuffer(const char* src);

                    MtpStringBuffer(const uint16_t* src);

    explicit        MtpStringBuffer(const uint16_t* src);

                    MtpStringBuffer(const MtpStringBuffer& src);

                    MtpStringBuffer(const MtpStringBuffer& src);

    virtual         ~MtpStringBuffer();

    virtual         ~MtpStringBuffer();