Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9fe846e4 authored by Roger I Nilsson's avatar Roger I Nilsson Committed by Takahiro Aizawa
Browse files

Remove possible div by zero in WavExtractor 

Do not accept 0 channels as a valid wav format.

Change-Id: I8d03d68f58d023b039503732736cc3a82ea560eb
parent 2d772fd4

media/libstagefright/WAVExtractor.cpp

+4 −2
Original line number Diff line number Diff line
@@ -194,12 +194,14 @@ status_t WAVExtractor::init() { 


            mNumChannels = U16_LE_AT(&formatSpec[2]);

            if (mWaveFormat != WAVE_FORMAT_EXTENSIBLE) {

                if (mNumChannels != 1 && mNumChannels != 2) {

                if (mNumChannels == 0) {

                    return ERROR_UNSUPPORTED;

                } else if (mNumChannels != 1 && mNumChannels != 2) {

                    ALOGW("More than 2 channels (%d) in non-WAVE_EXT, unknown channel mask",

                            mNumChannels);

                }

            } else {

                if (mNumChannels < 1 && mNumChannels > 8) {

                if (mNumChannels < 1 || mNumChannels > 8) {

                    return ERROR_UNSUPPORTED;

                }

            }