Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9b251f94 authored by Ray Essick's avatar Ray Essick Committed by Automerger Merge Worker
Browse files

Avoid returning value on stack am: 75e93e7b 

Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/av/+/15655397

Change-Id: Ifa640ee9d4e3084d4e515850bc40e3d0278bb4bc
parents c9691a7b 75e93e7b

media/ndk/NdkMediaFormat.cpp

+5 −2
Original line number Diff line number Diff line
@@ -200,8 +200,11 @@ bool AMediaFormat_getString(AMediaFormat* mData, const char *name, const char ** 
    AString tmp;

    if (mData->mFormat->findString(name, &tmp)) {

        String8 ret(tmp.c_str());

        mData->mStringCache.add(String8(name), ret);

        *out = ret.string();

        ssize_t i = mData->mStringCache.add(String8(name), ret);

        if (i < 0) {

            return false;

        }

        *out = mData->mStringCache.valueAt(i).string();

        return true;

    }

    return false;