Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9876eacd authored by Phil Burk's avatar Phil Burk
Browse files

aaudio_loopback: do not set buffer capacity by default 

That was causing us to not get a FAST track.

Bug: 112186931
Test: adb shell aaudio_loopback -te -pl -Pl -m1 -n2
Test: should get PerformanceMode 12 on INPUT
Change-Id: Ib8b00585a80bdd86f752a5ee37aacd92f06db347
parent d2e705a7

media/libaaudio/examples/loopback/src/loopback.cpp

+3 −10
Original line number Diff line number Diff line
@@ -338,7 +338,7 @@ int main(int argc, const char **argv) 
    aaudio_sharing_mode_t requestedInputSharingMode  = AAUDIO_SHARING_MODE_SHARED;

    int                   requestedInputChannelCount = NUM_INPUT_CHANNELS;

    aaudio_format_t       requestedInputFormat       = AAUDIO_FORMAT_UNSPECIFIED;

    int32_t               requestedInputCapacity     = -1;

    int32_t               requestedInputCapacity     = AAUDIO_UNSPECIFIED;

    aaudio_performance_mode_t inputPerformanceLevel  = AAUDIO_PERFORMANCE_MODE_LOW_LATENCY;



    int32_t               outputFramesPerBurst = 0;
@@ -459,15 +459,8 @@ int main(int argc, const char **argv) 
    argParser.setPerformanceMode(inputPerformanceLevel);

    argParser.setChannelCount(requestedInputChannelCount);

    argParser.setSharingMode(requestedInputSharingMode);



    // Make sure the input buffer has plenty of capacity.

    // Extra capacity on input should not increase latency if we keep it drained.

    int32_t inputBufferCapacity = requestedInputCapacity;

    if (inputBufferCapacity < 0) {

        int32_t outputBufferCapacity = AAudioStream_getBufferCapacityInFrames(outputStream);

        inputBufferCapacity = 2 * outputBufferCapacity;

    }

    argParser.setBufferCapacity(inputBufferCapacity);

    // Warning! If you change input capacity then you may not get a FAST track on Legacy path.

    argParser.setBufferCapacity(requestedInputCapacity);



    result = recorder.open(argParser);

    if (result != AAUDIO_OK) {