Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8fbf3fbb authored by Kwangkyu Park's avatar Kwangkyu Park
Browse files

Fix typo in ProviderInfo 

removeProvider() in CameraProviderManager works based on the provider
instance. However, there is a typo in ProviderInfo which still provides
a provider name.

Fix the typo to remove provider correctly.

Bug: 269232596
Test: existing CameraProviderManagerTest should pass
Change-Id: I77ad4a28ae64d7a9b01c3a09ad701805a31a2820
parent 5d431ebe

services/camera/libcameraservice/common/aidl/AidlProviderInfo.cpp

+1 −1
Original line number Diff line number Diff line
@@ -293,7 +293,7 @@ const std::shared_ptr<ICameraProvider> AidlProviderInfo::startProviderInterface( 
            if (link != STATUS_OK) {

                ALOGW("%s: Unable to link to provider '%s' death notifications",

                        __FUNCTION__, mProviderName.c_str());

                mManager->removeProvider(mProviderName);

                mManager->removeProvider(mProviderInstance);

                return nullptr;

            }

services/camera/libcameraservice/common/hidl/HidlProviderInfo.cpp

+1 −1
Original line number Diff line number Diff line
@@ -388,7 +388,7 @@ HidlProviderInfo::startProviderInterface() { 
                  __FUNCTION__,

                  mProviderName.c_str(),

                  linked.description().c_str());

              mManager->removeProvider(mProviderName);

              mManager->removeProvider(mProviderInstance);

              return nullptr;

            } else if (!linked) {

              ALOGW("%s: Unable to link to provider '%s' death notifications",