Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8ecf6338 authored by jiabin's avatar jiabin Committed by Jiabin Huang
Browse files

Enable modernize-use-nodiscard and modernize-use-override. 

The two flags were disabled due to failing on AIDL generated files.
Enabling them now as there are no more issues with the auto generated files.

Bug: 186572209
Test: make
Change-Id: If6eebbb3a1524ac68837900315cbc640f038f343
parent 9c06ce85

media/libaaudio/src/Android.bp

+2 −2
Original line number Diff line number Diff line
@@ -41,10 +41,10 @@ tidy_errors = [ 
    "modernize-use-emplace",

    "modernize-use-equals-default",

    "modernize-use-equals-delete",

    // "modernize-use-nodiscard", // found in aidl generated files

    "modernize-use-nodiscard",

    "modernize-use-noexcept",

    "modernize-use-nullptr",

    // "modernize-use-override", // found in aidl generated files

    "modernize-use-override",

    // "modernize-use-trailing-return-type", // not necessarily more readable

    "modernize-use-transparent-functors",

    "modernize-use-uncaught-exceptions",

services/oboeservice/Android.bp

+1 −1
Original line number Diff line number Diff line
@@ -55,7 +55,7 @@ tidy_errors = [ 
    "modernize-use-emplace",

    "modernize-use-equals-default",

    "modernize-use-equals-delete",

    // "modernize-use-nodiscard", // Maybe add this in the future

    "modernize-use-nodiscard",

    "modernize-use-noexcept",

    "modernize-use-nullptr",

    "modernize-use-override",