Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8e35c06f authored by Wonsik Kim's avatar Wonsik Kim
Browse files

codec2 hal: use SharedRefBase::ref() instead of shared_from_this 

Bug: 251850069
Test: adb shell dumpsys android.hardware.media.c2.IComponentStore/software
Change-Id: Ide7f5b8121b9f6536531b86733862bdcba795437
parent b613d4b9

media/codec2/hal/aidl/Component.cpp

+1 −1
Original line number Diff line number Diff line
@@ -411,7 +411,7 @@ void Component::initListener(const std::shared_ptr<Component>& self) { 


        mDeathRecipient = ::ndk::ScopedAIBinder_DeathRecipient(

                AIBinder_DeathRecipient_new(OnBinderDied));

        mDeathContext = new DeathContext{weak_from_this()};

        mDeathContext = new DeathContext{ref<Component>()};

        AIBinder_DeathRecipient_setOnUnlinked(mDeathRecipient.get(), OnBinderUnlinked);

        AIBinder_linkToDeath(mListener->asBinder().get(), mDeathRecipient.get(), mDeathContext);

    } else {

media/codec2/hal/aidl/ComponentStore.cpp

+1 −1
Original line number Diff line number Diff line
@@ -216,7 +216,7 @@ ScopedAStatus ComponentStore::createComponent( 
#endif

        onInterfaceLoaded(c2component->intf());

        std::shared_ptr<Component> comp =

            SharedRefBase::make<Component>(c2component, listener, shared_from_this(), pool);

            SharedRefBase::make<Component>(c2component, listener, ref<ComponentStore>(), pool);

        *component = comp;

        if (!component) {

            status = C2_CORRUPTED;

media/codec2/hal/aidl/include/codec2/aidl/Component.h

+1 −2
Original line number Diff line number Diff line
@@ -46,8 +46,7 @@ namespace utils { 


struct ComponentStore;



struct Component : public BnComponent,

                   public std::enable_shared_from_this<Component> {

struct Component : public BnComponent {

    Component(

            const std::shared_ptr<C2Component>&,

            const std::shared_ptr<IComponentListener>& listener,

media/codec2/hal/aidl/include/codec2/aidl/ComponentStore.h

+1 −2
Original line number Diff line number Diff line
@@ -50,8 +50,7 @@ struct Component; 


using ::aidl::android::hardware::media::bufferpool2::IClientManager;



struct ComponentStore : public BnComponentStore,

                        public std::enable_shared_from_this<ComponentStore> {

struct ComponentStore : public BnComponentStore {

    ComponentStore(const std::shared_ptr<C2ComponentStore>& store);

    virtual ~ComponentStore();