Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8da94180 authored by Shunkai Yao's avatar Shunkai Yao
Browse files

AudioFlinger: validate effect before access to avoid crash 

Bug: 324834453
Test: atest CtsMediaAudioTestCases
Change-Id: Ia1de56763feefd79b5940cfd9082402fd084c78f
parent f4a6c87c

services/audioflinger/AudioFlinger.cpp

+4 −3
Original line number Diff line number Diff line
@@ -4390,9 +4390,10 @@ void AudioFlinger::setEffectSuspended(int effectId, 
        return;

    }

    audio_utils::lock_guard _sl(thread->mutex());

    sp<IAfEffectModule> effect = thread->getEffect_l(sessionId, effectId);

    if (const auto& effect = thread->getEffect_l(sessionId, effectId)) {

        thread->setEffectSuspended_l(&effect->desc().type, suspended, sessionId);

    }

}





// moveEffectChain_ll must be called with the AudioFlinger::mutex()