Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d7d5613 authored by Aayush Soni's avatar Aayush Soni
Browse files

C2SoftMpeg4Dec: Fix memory leak in onRelease 

Test: POC in bug description
      atest VtsHalMediaC2V1_0TargetVideoDecTest
      atest -c CtsMediaV2TestCases:CodecDecoderTest

Bug: 193759243

Change-Id: I1b4511e733d02a2f573bcb5475b778beccaccbae
parent 953b19df

media/codec2/components/mpeg4_h263/C2SoftMpeg4Dec.cpp

+6 −17
Original line number Diff line number Diff line
@@ -243,12 +243,14 @@ c2_status_t C2SoftMpeg4Dec::onInit() { 
}



c2_status_t C2SoftMpeg4Dec::onStop() {

    if (mInitialized) {

    if (mDecHandle) {

        if (mInitialized) {

            PVCleanUpVideoDecoder(mDecHandle);

        }

            mInitialized = false;

        }

        delete mDecHandle;

        mDecHandle = nullptr;

    }

    for (int32_t i = 0; i < kNumOutputBuffers; ++i) {

        if (mOutputBuffer[i]) {

            free(mOutputBuffer[i]);
@@ -269,23 +271,10 @@ void C2SoftMpeg4Dec::onReset() { 
}



void C2SoftMpeg4Dec::onRelease() {

    if (mInitialized) {

        if (mDecHandle) {

            PVCleanUpVideoDecoder(mDecHandle);

            delete mDecHandle;

            mDecHandle = nullptr;

        }

        mInitialized = false;

    }

    (void)onStop();

    if (mOutBlock) {

        mOutBlock.reset();

    }

    for (int32_t i = 0; i < kNumOutputBuffers; ++i) {

        if (mOutputBuffer[i]) {

            free(mOutputBuffer[i]);

            mOutputBuffer[i] = nullptr;

        }

    }

}



c2_status_t C2SoftMpeg4Dec::onFlush_sm() {