Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8616d814 authored by Haripriya Deshmukh's avatar Haripriya Deshmukh
Browse files

amrnb: Enable integer sanitizer

Bug: 357558004
Bug: 25409744
Test: atest CtsMediaV2TestCases
Test: atest MctsMediaV2TestCases
Test: atest VtsHalMediaC2V1_0TargetAudioDecTest
Test: atest VtsHalMediaC2V1_0TargetAudioEncTest
Test: atest AmrnbDecoderTest AmrnbEncoderTest
Test: atest AmrwbDecoderTest AmrwbEncoderTest

Change-Id: I10230ac1da1dd277d58c3d50baec014a946555bf
parent b8d0f0c8
Loading
Loading
Loading
Loading
+10 −10
Original line number Diff line number Diff line
package {
    default_team: "trendy_team_media_codec_framework",
    default_applicable_licenses: [
        "frameworks_av_media_codecs_amrnb_common_license",
    ],
@@ -42,8 +43,8 @@ cc_library {
        "src/gains_tbl.cpp",
        "src/gc_pred.cpp",
        "src/gmed_n.cpp",
        "src/grid_tbl.cpp",
        "src/gray_tbl.cpp",
        "src/grid_tbl.cpp",
        "src/int_lpc.cpp",
        "src/inv_sqrt.cpp",
        "src/inv_sqrt_tbl.cpp",
@@ -91,9 +92,9 @@ cc_library {
    export_include_dirs: ["include"],

    cflags: [
        "-DOSCL_UNUSED_ARG(x)=(void)(x)",
        "-DOSCL_IMPORT_REF=",
        "-DOSCL_EXPORT_REF=",
        "-DOSCL_IMPORT_REF=",
        "-DOSCL_UNUSED_ARG(x)=(void)(x)",

        "-Werror",
    ],
@@ -104,11 +105,10 @@ cc_library {
        },
    },

    //addressing b/25409744
    //sanitize: {
    //    misc_undefined: [
    //        "signed-integer-overflow",
    //        "unsigned-integer-overflow",
    //    ],
    //},
    sanitize: {
        misc_undefined: [
            "signed-integer-overflow",
            "unsigned-integer-overflow",
        ],
    },
}
+23 −17
Original line number Diff line number Diff line
package {
    default_team: "trendy_team_media_codec_framework",
    default_applicable_licenses: [
        "frameworks_av_media_codecs_amrnb_dec_license",
    ],
@@ -47,12 +48,12 @@ cc_library_static {
        "src/b_cn_cod.cpp",
        "src/bgnscd.cpp",
        "src/c_g_aver.cpp",
        "src/d1035pf.cpp",
        "src/d2_11pf.cpp",
        "src/d2_9pf.cpp",
        "src/d2_11pf.cpp",
        "src/d3_14pf.cpp",
        "src/d4_17pf.cpp",
        "src/d8_31pf.cpp",
        "src/d1035pf.cpp",
        "src/d_gain_c.cpp",
        "src/d_gain_p.cpp",
        "src/d_plsf.cpp",
@@ -81,21 +82,22 @@ cc_library_static {
    export_include_dirs: ["src"],

    cflags: [
        "-DOSCL_UNUSED_ARG(x)=(void)(x)",
        "-DOSCL_IMPORT_REF=",
        "-DOSCL_UNUSED_ARG(x)=(void)(x)",

        "-Werror",
    ],

    //sanitize: {
    //    misc_undefined: [
    //        "signed-integer-overflow",
    //    ],
    //},
    sanitize: {
        misc_undefined: [
            "signed-integer-overflow",
            "unsigned-integer-overflow",
        ],
    },

    shared_libs: [
        "libstagefright_amrnb_common",
        "liblog",
        "libstagefright_amrnb_common",
    ],

    target: {
@@ -113,19 +115,22 @@ cc_test {

    srcs: ["test/amrnbdec_test.cpp"],

    cflags: ["-Wall", "-Werror"],
    cflags: [
        "-Wall",
        "-Werror",
    ],

    local_include_dirs: ["src"],

    static_libs: [
        "libstagefright_amrnbdec",
        "libsndfile",
        "libstagefright_amrnbdec",
    ],

    shared_libs: [
        "libstagefright_amrnb_common",
        "libaudioutils",
        "liblog",
        "libstagefright_amrnb_common",
    ],

    target: {
@@ -134,9 +139,10 @@ cc_test {
        },
    },

    //sanitize: {
    //    misc_undefined: [
    //        "signed-integer-overflow",
    //    ],
    //},
    sanitize: {
        misc_undefined: [
            "signed-integer-overflow",
            "unsigned-integer-overflow",
        ],
    },
}
+19 −15
Original line number Diff line number Diff line
package {
    default_team: "trendy_team_media_codec_framework",
    default_applicable_licenses: [
        "frameworks_av_media_codecs_amrnb_enc_license",
    ],
@@ -42,12 +43,12 @@ cc_library_static {
    srcs: [
        "src/amrencode.cpp",
        "src/autocorr.cpp",
        "src/c1035pf.cpp",
        "src/c2_11pf.cpp",
        "src/c2_9pf.cpp",
        "src/c2_11pf.cpp",
        "src/c3_14pf.cpp",
        "src/c4_17pf.cpp",
        "src/c8_31pf.cpp",
        "src/c1035pf.cpp",
        "src/calc_cor.cpp",
        "src/calc_en.cpp",
        "src/cbsearch.cpp",
@@ -107,12 +108,12 @@ cc_library_static {
        "-Werror",
    ],

    //addressing b/25409744
    //sanitize: {
    //    misc_undefined: [
    //        "signed-integer-overflow",
    //    ],
    //},
    sanitize: {
        misc_undefined: [
            "signed-integer-overflow",
            "unsigned-integer-overflow",
        ],
    },

    shared_libs: ["libstagefright_amrnb_common"],

@@ -132,7 +133,10 @@ cc_test {

    srcs: ["test/amrnb_enc_test.cpp"],

    cflags: ["-Wall", "-Werror"],
    cflags: [
        "-Wall",
        "-Werror",
    ],

    local_include_dirs: ["src"],

@@ -140,10 +144,10 @@ cc_test {

    shared_libs: ["libstagefright_amrnb_common"],

    //addressing b/25409744
    //sanitize: {
    //    misc_undefined: [
    //        "signed-integer-overflow",
    //    ],
    //},
    sanitize: {
        misc_undefined: [
            "signed-integer-overflow",
            "unsigned-integer-overflow",
        ],
    },
}
+8 −1
Original line number Diff line number Diff line
@@ -19,6 +19,7 @@
 */

package {
    default_team: "trendy_team_media_codec_framework",
    // See: http://go/android-license-faq
    // A large-scale-change added 'default_applicable_licenses' to import
    // all of the 'license_kinds' from "frameworks_av_media_codecs_amrnb_enc_license"
@@ -39,8 +40,8 @@ cc_fuzz {

    static_libs: [
        "liblog",
        "libstagefright_amrnbenc",
        "libstagefright_amrnb_common",
        "libstagefright_amrnbenc",
    ],

    fuzz_config: {
@@ -57,4 +58,10 @@ cc_fuzz {
        users: "multi_user",
        fuzzed_code_usage: "shipped",
    },
    sanitize: {
        misc_undefined: [
            "signed-integer-overflow",
            "unsigned-integer-overflow",
        ],
    },
}
+9 −2
Original line number Diff line number Diff line
@@ -19,6 +19,7 @@
 */

package {
    default_team: "trendy_team_media_codec_framework",
    // See: http://go/android-license-faq
    // A large-scale-change added 'default_applicable_licenses' to import
    // all of the 'license_kinds' from "frameworks_av_license"
@@ -34,9 +35,9 @@ cc_fuzz {
        "amrnb_dec_fuzzer.cpp",
    ],
    static_libs: [
        "libstagefright_amrnbdec",
        "libstagefright_amrnb_common",
        "liblog",
        "libstagefright_amrnb_common",
        "libstagefright_amrnbdec",
    ],
    target: {
        darwin: {
@@ -57,4 +58,10 @@ cc_fuzz {
        users: "multi_user",
        fuzzed_code_usage: "shipped",
    },
    sanitize: {
        misc_undefined: [
            "signed-integer-overflow",
            "unsigned-integer-overflow",
        ],
    },
}